Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 462832 - app-text/recode fails to compile with sys-devel/clang-3.2
Summary: app-text/recode fails to compile with sys-devel/clang-3.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low normal with 1 vote (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: systemwide-clang
  Show dependency tree
 
Reported: 2013-03-23 16:47 UTC by Agostino Sarubbo
Modified: 2016-06-02 12:52 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,332.62 KB, text/plain)
2013-03-23 16:47 UTC, Agostino Sarubbo
Details
Add "static" to aliases_lookup function declaration. (fix-aliases-h.patch,377 bytes, patch)
2014-08-11 13:05 UTC, Fabio Scaccabarozzi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2013-03-23 16:47:29 UTC
You receive this bug because the package in the ${summary} fails to compile if I set sys-devel/clang as default compiler.

To reproduce this is issue:
1) emerge sys-devel/clang
2) declare CC=clang and CXX=clang++ into /etc/portage/env/clang
3) add "${package} clang" to /etc/portage/package.env


# clang -v
clang version 3.2 (tags/RELEASE_32/final)
Target: x86_64-pc-linux-gnu
Thread model: posix

Additional info:

Portage 2.1.11.31 (default/linux/amd64/13.0, gcc-4.6.3, glibc-2.15-r3, 3.2.38 x86_64)
=================================================================
System uname: Linux-3.2.38-x86_64-QEMU_Virtual_CPU_version_1.2.2-with-gentoo-2.1
ld GNU ld (GNU Binutils) 2.22
app-shells/bash:          4.2_p37
dev-lang/python:          2.7.3-r2, 3.2.3
dev-util/pkgconfig:       0.27.1
sys-apps/baselayout:      2.1-r1
sys-apps/openrc:          0.11.8
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.69                                                                                                                                                      
sys-devel/automake:       1.11.6                                                                                                                                                    
sys-devel/binutils:       2.22-r1                                                                                                                                                   
sys-devel/gcc:            4.6.3                                                                                                                                                     
sys-devel/gcc-config:     1.7.3                                                                                                                                                     
sys-devel/libtool:        2.4-r1                                                                                                                                                    
sys-devel/make:           3.82-r4                                                                                                                                                   
sys-kernel/linux-headers: 3.6 (virtual/os-headers)                                                                                                                                  
sys-libs/glibc:           2.15-r3                                                                                                                                                   
Repositories: gentoo                                                                                                                                                                
ACCEPT_KEYWORDS="amd64"                                                                                                                                                             
ACCEPT_LICENSE="*"                                                                                                                                                                  
CBUILD="x86_64-pc-linux-gnu"                                                                                                                                                        
CFLAGS="-O2"                                                                                                                                                                        
CHOST="x86_64-pc-linux-gnu"                                                                                                                                                         
CONFIG_PROTECT="/etc"                                                                                                                                                               
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"                                                              
CXXFLAGS="-O2"                                                                                                                                                                      
DISTDIR="/usr/portage/distfiles"                                                                                                                                                    
FCFLAGS="-O2 -pipe"                                                                                                                                                                 
FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch protect-owned sandbox sfperms sign split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"                                                                      
FFLAGS="-O2 -pipe"                                                                                                                                                                  
GENTOO_MIRRORS="http://192.168.2.3 http://distfiles.gentoo.org"                                                                                                                     
LDFLAGS="-Wl,-O1 -Wl,--as-needed"                                                                                                                                                   
MAKEOPTS="-j4"                                                                                                                                                                      
PKGDIR="/usr/portage/packages"                                                                                                                                                      
PORTAGE_CONFIGROOT="/"                                                                                                                                                              
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"                                                                                                                                                         
PORTAGE_TMPDIR="/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://192.168.2.3/gentoo-portage"
USE="acl amd64 berkdb bindist bzip2 cli cracklib crypt cxx dri fortran gdbm gpm iconv ipv6 mmx modules mudflap multilib ncurses nls nptl openmp pam pcre readline session sse sse2 ssl tcpd unicode zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" PHP_TARGETS="php5-3" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby18 ruby19" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Comment 1 Agostino Sarubbo gentoo-dev 2013-03-23 16:47:39 UTC
Created attachment 343006 [details]
build.log

build log
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2013-04-06 09:42:34 UTC
It is reproducible, but I can't find an easy solution. Patches welcome.
Comment 3 Hendrik v. Raven 2013-04-08 11:55:49 UTC
The problem is in libiconv/aliases.h:69:

#ifdef __GNUC__
__inline
#endif
const struct alias *
aliases_lookup (register const char *str, register unsigned int len)

The code part there leads to inlining under gcc. If the code doesn't get inlined (like in clang) the header just get's included in iconv.c, but not compiled. With C99 inline would be standarized and work. __inline would work in clang, too.
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2013-04-09 06:33:59 UTC
(In reply to comment #3)
> The problem is in libiconv/aliases.h:69:
> 
> #ifdef __GNUC__
> __inline
> #endif
> const struct alias *
> aliases_lookup (register const char *str, register unsigned int len)
> 
> The code part there leads to inlining under gcc. If the code doesn't get
> inlined (like in clang) the header just get's included in iconv.c, but not
> compiled. With C99 inline would be standarized and work. __inline would work
> in clang, too.

That means?? Hwo to fix that?
Comment 5 Austin English (RETIRED) gentoo-dev 2014-02-25 21:03:26 UTC
Still in clang-3.3
Comment 6 Fabio Scaccabarozzi 2014-08-11 13:05:43 UTC
Created attachment 382672 [details, diff]
Add "static" to aliases_lookup function declaration.

Fixes the compilation by adding the "static" keyword to the aliases_lookup function. The purpose of the functions contained in libiconv/aliases.h seems to be of always being inlined no matter what.
Changing from C89 to C99 changes the semantics of the "inline" keyword according to the clang website.
I have tried using inline, __inline, __gnu_inline__ all to no avail. Adding "static" allows the compilation to continue. In practice "static" hides the symbols from the linker, which become only visible only by the translation unit being compiled and can be then optimized away (which, reading the code, seems to be the original intention).
More reading here:
http://stackoverflow.com/questions/5319361/static-function-in-c

Tests pass fine both with clang-3.4.2 and gcc-4.8.3.
Comment 7 Fabio Scaccabarozzi 2015-01-19 21:58:35 UTC
The patch still applies for recode-3.6_p20 compiled with clang-3.5.0.
Applying the patch makes recode compile and pass tests.
Comment 8 Valeriy Malov 2016-02-20 20:49:05 UTC
app-text/recode-3.6_p20-r1 seems to build fine without the static patch with clang 3.7.1, but I can't find any info on changes to how clang handles __inline
Comment 9 Austin English (RETIRED) gentoo-dev 2016-06-02 06:25:28 UTC
(In reply to Valeriy Malov from comment #8)
> app-text/recode-3.6_p20-r1 seems to build fine without the static patch with
> clang 3.7.1, but I can't find any info on changes to how clang handles
> __inline

clang 3.5 also works, so it may not be a clang change. Unfortunately the previous ebuild is not in git, so I can't easily see what app-text/recode-3.6_p20.ebuild did differently.

Anyway, WORKSFORME. Agostino, can you retry?
Comment 10 Agostino Sarubbo gentoo-dev 2016-06-02 12:50:26 UTC
(In reply to Austin English from comment #9)
> (In reply to Valeriy Malov from comment #8)
> > app-text/recode-3.6_p20-r1 seems to build fine without the static patch with
> > clang 3.7.1, but I can't find any info on changes to how clang handles
> > __inline
> 
> clang 3.5 also works, so it may not be a clang change. Unfortunately the
> previous ebuild is not in git, so I can't easily see what
> app-text/recode-3.6_p20.ebuild did differently.
> 
> Anyway, WORKSFORME. Agostino, can you retry?

If the current recode works with the current clang feel free to close..
Comment 11 Agostino Sarubbo gentoo-dev 2016-06-02 12:52:11 UTC
tested. works for me.