Bug 454300 – net-libs/cyassl does not respect CFLAGS

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2013-01-27 13:07:33 UTC]

* C Compiler:                x86_64-pc-linux-gnu-gcc (Gentoo 4.6.3 p1.11, pie-0.5.2) 4.6.3
   * C Flags:                    -g -ggdb -O0 -Wno-pragmas -Wall -Wno-strict-aliasing -Wextra -Wunknown-pragmas --param=ssp-buffer-size=1 -Waddress -Warray-bounds -Wbad-function-cast -Wchar-subscripts -Wcomment -Wfloat-equal -Wformat-security -Wformat=2 -Wmissing-field-initializers -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wnormalized=id -Woverride-init -Wpointer-arith -Wpointer-sign -Wredundant-decls -Wshadow -Wsign-compare -Wstrict-overflow=1 -Wswitch-enum -Wundef -Wunused -Wunused-result -Wunused-variable -Wwrite-strings -fwrapv

And you should drop "-g -ggdb -O0"

[Comment 1 Anthony Basile 2013-01-29 03:18:03 UTC]

Okay one bug at a time.  First the "-g -ggdb -O0" CFLAGS.  These should *only* be there when USE="debug".  However, USE="-debug" does not remove them because of an incorrect implementation of AC_ARG_ENABLE.

I've sent the patch upstream and I'll attach here for backporting to 2.4.6.

https://sourceforge.net/tracker/?func=detail&aid=3602468&group_id=129181&atid=714511


Next the disrespect for user provided CFLAGS ....

[Comment 2 Anthony Basile 2013-01-29 19:19:41 UTC]

Created attachment 337266 [details, diff]
Correct poor implementation of AC_ARG_ENABLE for --enable/disable-debug

[Comment 3 Agostino Sarubbo 2013-01-30 16:04:34 UTC]

is this fixed in the tree?

[Comment 4 Anthony Basile 2013-01-30 23:44:27 UTC]

(In reply to comment #3)
> is this fixed in the tree?

Not yet.  These is also an issue with repsecting CXXFLAGS which is minor but should still be fixed.

I'll push the -g -ggdb fix now since it is more serious.

[Comment 5 Anthony Basile 2013-01-31 14:55:31 UTC]

Okay CFLAGS issue and --enable/disable-debug issue both fixed.  Please test/reopen if this is still an issue.  It works for me.