Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 439660 - net-fs/nfs-utils nfsmount init script should drop need net
Summary: net-fs/nfs-utils nfsmount init script should drop need net
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Network Filesystems
URL:
Whiteboard:
Keywords:
Depends on: 439658
Blocks: need-net
  Show dependency tree
 
Reported: 2012-10-25 18:31 UTC by Matthew Schultz
Modified: 2013-03-24 20:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Schultz 2012-10-25 18:31:39 UTC
This service fails to start on a my machine with a nfs network root mounted filesystem:

Service `nfsmount' needs non existent service `net'

Reproducible: Always
Comment 1 SpanKY gentoo-dev 2012-11-11 05:54:18 UTC
that makes no sense.  nfsmount needs the network, so it needs to be started after the network is up.

i'm not sure if "after net" will fly in terms of shutting down.  openrc has to know that it can't turn off the network before it stops the nfsmount init.d.
Comment 2 William Hubbs gentoo-dev 2012-11-18 21:35:39 UTC
The problem is that depending on the "net" virtual can't and doesn't
tell you when the route to the server where the file system is stored is
actually active. You get a better dependency by having users set
rc_need="net.foo" or whatever they need in their /etc/conf.d/nfsmount
file.
Comment 3 SpanKY gentoo-dev 2012-11-19 08:02:25 UTC
(In reply to comment #2)

yes, you get "better" resolution, but a default of ignoring net altogether is an awful user experience

"after net" will be a fine default for startup, but i'm not sure about shutdown without actually reading code/testing.  do you know off the top of your head William ?
Comment 4 William Hubbs gentoo-dev 2012-11-19 15:07:28 UTC
After net should work.

Actually what I would do is put it in the conf.d file like this:
rc_after="net"

Then explain to the user with documentation in there that they
can/should adjust it.
Comment 5 William Hubbs gentoo-dev 2012-11-19 15:10:00 UTC
Considering what you just said, you may want to get this to go to stable
asap after openrc-0.11.5. I just filed a stablereq for it because newer
OpenRC is needed in stable for several reasons now.
Comment 6 SpanKY gentoo-dev 2012-11-19 20:31:41 UTC
(In reply to comment #4)

that works for me.  the netmount script with openrc should do the same thing as its current default (not depending on net at all) is wrong.
Comment 7 SpanKY gentoo-dev 2013-03-24 20:29:55 UTC
should be all set now in the tree; thanks for the report!

Commit message: Move net usage to conf.d (defaults are unchanged)
http://sources.gentoo.org/net-fs/nfs-utils/files/nfsmount.confd?rev=1.1
http://sources.gentoo.org/net-fs/nfs-utils/files/nfsmount.initd?r1=1.14&r2=1.15
http://sources.gentoo.org/net-fs/nfs-utils/nfs-utils-1.2.6.ebuild?r1=1.13&r2=1.14