Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 414961 - Feature Request to make ":" a replacement for ${PORTDIR}/profiles
Summary: Feature Request to make ":" a replacement for ${PORTDIR}/profiles
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
: 331683 (view as bug list)
Depends on:
Blocks: 240187 428678 409383
  Show dependency tree
 
Reported: 2012-05-07 03:15 UTC by Martin Scholz
Modified: 2012-09-03 22:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
support colon in profile parent with profile-formats = portage-2 (Substitute-colon-in-profile-parent.patch,4.11 KB, patch)
2012-05-10 22:48 UTC, Zac Medico
Details | Diff
Profile parent repo: references (Profile-parent-repo-references.patch,4.86 KB, patch)
2012-05-16 04:32 UTC, Zac Medico
Details | Diff
Profile parent repo: references (Profile-parent-repo-references.patch,5.03 KB, patch)
2012-05-17 00:26 UTC, Zac Medico
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Scholz 2012-05-07 03:15:25 UTC
As spoken with zmedico on IRC it would be nice for the /etc/portage/make.profile/parents to have a ":" as a replacement for ${PORTDIR}/profiles.

Would be nice to get it included :)

Thx so far
Comment 1 Zac Medico gentoo-dev 2012-05-07 04:01:52 UTC
This should be easy to do nowadays, since the recently added profile-formats support makes LocationsManager aware of repo paths.
Comment 2 Sebastian Luther (few) 2012-05-07 13:45:08 UTC
What about inventing a syntax that allows using repository names? Once you allow to reference $PORTDIR, people are going to ask for reference to some overlay.

This thing needs an EAPI change as the parents file is under EAPI control.

IIRC there is already a bug asking for something like that.
Comment 3 Daniel Robbins 2012-05-07 15:45:55 UTC
I would be fine with the ability to specify repo names. Having a shorthand to mean "relative to PORTDIR/profiles" (ie. ":") is also a good thing.
Comment 4 Zac Medico gentoo-dev 2012-05-07 18:22:21 UTC
(In reply to comment #2)
> This thing needs an EAPI change as the parents file is under EAPI control.

We are already using "profile-formats = portage-1" in metadata/layout.conf to indicate that directories can be used in place of files. So, we could enable this extension with "profile-formats = portage-2" or something like that.
Comment 5 Zac Medico gentoo-dev 2012-05-10 22:48:14 UTC
Created attachment 311391 [details, diff]
support colon in profile parent with profile-formats = portage-2
Comment 6 Zac Medico gentoo-dev 2012-05-10 23:04:32 UTC
Feedback from irc:

<drobbins> zmedico: that's the tricky thing - we are going to use the syntax in /etc/portage/make.profile/parent
<drobbins> zmedico: as an easy way to link into the portdir
<zmedico> drobbins: hmm, so we need to somehow know PORTDIR beforehand? that's tricky
<drobbins> zmedico: yeah
<drobbins> zmedico: now, that's why I had another kewl patch that used /etc/portage/portdir to define the portdir
<drobbins> zmedico: so /etc/make.conf would not need to be parsed first.
<drobbins> zmedico: this is the chicken and egg part.
<zmedico> drobbins: would be simpler if we make if funtoo:
<zmedico> that way, PORTDIR is irrelevant
<zmedico> I mean, specify repo name in the parent file
<drobbins> so we would have <repo-name>:asdlfkasd
<drobbins> or similar syntax (I'm flexible)
<zmedico> right
<drobbins> that would be perfectly fine.
Comment 7 Paul Varner (RETIRED) gentoo-dev 2012-05-11 15:35:52 UTC
Don't stop any work on this, but I'm adding tools-portage to the CC, because there is a strong possibility that this will break things in gentoolkit.
Comment 8 Zac Medico gentoo-dev 2012-05-16 04:32:37 UTC
Created attachment 311927 [details, diff]
Profile parent repo: references

This applies to 2.2.0_alpha105 or 2.1.10.60.
Comment 9 Paul Varner (RETIRED) gentoo-dev 2012-05-16 19:18:27 UTC
In testing the patch with Portage 2.1.10.60, except for 'euse' everything in gentoolkit appears to be working fine.  I did not encounter any other portage or gentoolkit errors in the testing.
Comment 10 Zac Medico gentoo-dev 2012-05-16 20:53:05 UTC
(In reply to comment #8)
> Created attachment 311927 [details, diff] [details, diff]
> Profile parent repo: references
> 
> This applies to 2.2.0_alpha105 or 2.1.10.60.

There's a bug in this patch related to the RepoConfig.portage1_profiles attribute, which prevents the config-file-as-directory extension from working correctly for portage-2. As a workaround, setting "profile-formats = portage-1 portage-2" should give the desired result.

I'll rebase the patch on top of the following related commit:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=f39ac7dc706544d1f36392c7def6da0b9b6bebcf
Comment 11 Zac Medico gentoo-dev 2012-05-17 00:26:12 UTC
Created attachment 312071 [details, diff]
Profile parent repo: references

This applies to 2.2.0_alpha107 or 2.1.10.62, and fixes the issue discussed in comment #10.
Comment 12 Oleh 2012-05-17 11:48:33 UTC
last attached diff works with portage-2 only enabled
Comment 14 Zac Medico gentoo-dev 2012-06-18 20:03:06 UTC
This is fixed in 2.1.10.65 and 2.2.0_alpha110.
Comment 15 Zac Medico gentoo-dev 2012-09-03 22:29:37 UTC
*** Bug 331683 has been marked as a duplicate of this bug. ***