Bug 414547 – media-libs/libmediainfo-0.7.57 unrecognized options: --with-libtinyxml

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Gilbert 2012-05-04 01:30:31 UTC]

Created attachment 310725 [details]
build log

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking --enable-shared --with-libtinyxml --without-libcurl --without-libmms --disable-static --disable-staticlibs
configure: WARNING: unrecognized options: --with-libtinyxml

[Comment 1 Julian Ospald 2012-05-04 01:43:53 UTC]

Created attachment 310727 [details, diff]
libmediainfo-0.7.57.diff

--with-libtinyxml 

to

--with-libtinyxml2

[Comment 2 Mike Gilbert 2012-05-04 01:51:27 UTC]

Created attachment 310729 [details]
build log 2

I get a build failure after applying that patch.

[Comment 3 Mike Gilbert 2012-05-04 02:51:55 UTC]

It looks like libmediainfo switched from tinyxml to tinyxml2, which is a different project. tinyxml2 is not currently in the tree.

I'm not sure if it is worth packaging tinyxml2, since it is configured as a static library by upstream.

[Comment 4 Julian Ospald 2012-05-04 02:59:40 UTC]

Created attachment 310733 [details, diff]
libmediainfo-0.7.57.diff

correct, both
--with-libtinyxml
and
--with-libtinyxml2 (this one exists)

were broken, so we should force the bundled one via 

--without-libtinyxml2

[Comment 5 Tim Harder 2012-05-04 20:50:57 UTC]

(In reply to comment #4)
...
> were broken, so we should force the bundled one
... 

No, we should avoid using bundled libraries when possible which is why tinyxml was originally unbundled from libmediainfo in the first place.

[Comment 6 Julian Ospald 2012-05-04 21:24:05 UTC]

> No, we should avoid using bundled libraries when possible which is why
> tinyxml was originally unbundled from libmediainfo in the first place.

right, but it is statically linked anyhow afais

[Comment 7 Mike Gilbert 2012-05-04 21:26:53 UTC]

The build system could be patched to fix that.

[Comment 8 Julian Ospald 2012-05-04 22:33:45 UTC]

Created attachment 310821 [details, diff]
cmake.patch

proposal

also see https://github.com/leethomason/tinyxml2/pull/21

[Comment 9 Tim Harder 2012-05-31 10:21:59 UTC]

Fixed in 0.7.58.