Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 409997 - media-sound/qsynth-0.3.6: assorted ebuild improvements
Summary: media-sound/qsynth-0.3.6: assorted ebuild improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks: qt4eclass
  Show dependency tree
 
Reported: 2012-03-28 13:30 UTC by Michael Palimaka (kensington)
Modified: 2012-05-07 10:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
qsynth-0.3.6.ebuild.patch (qsynth-0.3.6.ebuild.patch,1.72 KB, patch)
2012-03-28 13:30 UTC, Michael Palimaka (kensington)
Details | Diff
qsynth-0.3.6.ebuild.patch (qsynth-0.3.6.ebuild.patch,1.85 KB, patch)
2012-03-28 15:29 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2012-03-28 13:30:45 UTC
Created attachment 306973 [details, diff]
qsynth-0.3.6.ebuild.patch

While intended to primarily migrate to the qt4-r2 eclass, the attached ebuild patch also bumps EAPI and respects LINGUAS.
Comment 1 Alexis Ballier gentoo-dev 2012-03-28 13:44:52 UTC
+	local lang
+	for lang in ${LANGS} ; do
+		if ! use linguas_${lang} ; then
+			rm -r "${D}"/usr/share/locale/${PN}_${lang}.qm
+		fi
+	done
+

is it really the only way? it'd be cleaner if those files were just not installed.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2012-03-28 15:29:41 UTC
Created attachment 306993 [details, diff]
qsynth-0.3.6.ebuild.patch

New and improved patch.
Comment 3 Johannes Huber (RETIRED) gentoo-dev 2012-04-22 15:47:44 UTC
(In reply to comment #1)
> +	local lang
> +	for lang in ${LANGS} ; do
> +		if ! use linguas_${lang} ; then
> +			rm -r "${D}"/usr/share/locale/${PN}_${lang}.qm
> +		fi
> +	done
> +
> 
> is it really the only way? it'd be cleaner if those files were just not
> installed.

Yes if upstream do the localization not in the standard style.
Comment 4 Davide Pesavento gentoo-dev 2012-05-06 22:52:20 UTC
Alexis, ping?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-05-06 23:02:50 UTC
It may not be perfect, but I can't see this a valid reason to hold up the qt4-r2 migration, so go ahead and apply the patch
We can improve *the style* for linguas handling in a version/revision bump later
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2012-05-06 23:10:38 UTC
Or rather just leave the linguas handling out of the patch and migrate the ebuild to qt4-r2 in a trivial way to avoid the hold up.
Comment 7 Alexis Ballier gentoo-dev 2012-05-07 00:39:09 UTC
(In reply to comment #2)
> Created attachment 306993 [details, diff] [details, diff]
> qsynth-0.3.6.ebuild.patch
> 
> New and improved patch.

sorry, forgot to reply here...

this new patch sounds good, feel free to apply, thanks
Comment 8 Ben de Groot (RETIRED) gentoo-dev 2012-05-07 10:41:01 UTC
Applied in CVS. Thanks Michael for the patch!