Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 379193 - dev-python/pydb-1.26: fix Emacs support
Summary: dev-python/pydb-1.26: fix Emacs support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords: TESTED
Depends on:
Blocks: 184166
  Show dependency tree
 
Reported: 2011-08-14 20:07 UTC by Ulrich Müller
Modified: 2011-12-24 13:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (pydb.patch,1.04 KB, patch)
2011-12-23 15:37 UTC, Ian Delaney (RETIRED)
Details | Diff
Proposed patch for pydb-1.26.ebuild (pydb-1.26.ebuild.diff,2.75 KB, patch)
2011-12-23 20:52 UTC, Ulrich Müller
Details | Diff
Proposed patch for pydb-1.26.ebuild (pydb-1.26.ebuild.diff,1.12 KB, patch)
2011-12-23 20:54 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2011-08-14 20:07:17 UTC
pydb-1.26 should depend on virtual/emacs instead of app-editors/emacs. Furthermore, the ebuild installs Emacs lisp files directly into /usr/share/emacs/site-lisp/. By our (Emacs team) policy they should go to a subdirectory instead.

A possible solution would use elisp-common.eclass which would take care of these issues automatically.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2011-12-23 15:37:08 UTC
Created attachment 296753 [details, diff]
ebuild patch
Comment 2 Ulrich Müller gentoo-dev 2011-12-23 20:52:48 UTC
Created attachment 296785 [details, diff]
Proposed patch for pydb-1.26.ebuild

(In reply to comment #1)
> ebuild patch

That doesn't work: There's no elisp-common_src_install function. Also, emacs support should be made optional, otherwise it will be an automagic dependency.

Please try attached patch.
Comment 3 Ulrich Müller gentoo-dev 2011-12-23 20:54:00 UTC
Created attachment 296787 [details, diff]
Proposed patch for pydb-1.26.ebuild
Comment 4 Andrey Grozin gentoo-dev 2011-12-24 13:26:07 UTC
Many thanks, I've applied your patch. The reason I haven't dealt with this bug much earlier is: the upstream has deprecated pydb in favor of pydbgr (http://code.google.com/p/pydbgr/). I hoped to write an ebuild for pydbgr quickly, and then to lastrite pydb. Unfortunately, pydbgr does not work for me, and I haven't yet understood why. So, for now, let pydb be in the tree - at least, it works.