Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 373661 - versionator.eclass: Update to match PMS's version sorting behavior
Summary: versionator.eclass: Update to match PMS's version sorting behavior
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 174542
  Show dependency tree
 
Reported: 2011-07-01 00:54 UTC by Jonathan Callen (RETIRED)
Modified: 2011-07-21 20:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for versionator.eclass (versionator.eclass.patch,13.03 KB, patch)
2011-07-01 00:54 UTC, Jonathan Callen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Callen (RETIRED) gentoo-dev 2011-07-01 00:54:59 UTC
Created attachment 278745 [details, diff]
Patch for versionator.eclass

Currently, versionator.eclass has a few flaws in it's behavior when comparing version strings. For example, it only supports one _alpha/_beta/_rc/_pre/_p/-r suffix, and it treats versions like "1.010" and "1.2.0" incorrectly (when comparing to "1.1" (should be *less*, versionator says *greater*) and "1.2" (should be *greater*, versionator says *equal*), respectively).

Attached is a patch that fixes the logic to match PMS, as well as fixing a couple test cases and adding a bunch more, pulled from portage's and paludis's testsuites.
Comment 1 SpanKY gentoo-dev 2011-07-01 02:18:21 UTC
base-system took over versionator.eclass once ciaranm left as it was the only logical group for it.  this is clearly reflected in the commit history.

if you're comfortable with hacking on it, then i'd say feel free to commit to it
Comment 2 Jonathan Callen (RETIRED) gentoo-dev 2011-07-21 20:20:16 UTC
I committed this a while ago.