Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 364921 - sys-apps/ccs-tools fails with forced --as-needed
Summary: sys-apps/ccs-tools fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: MATSUU Takuto (RETIRED)
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2011-04-26 12:14 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2011-09-29 21:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (ccs-tools-1.8.0_p20110214:20110425-210435.log,24.66 KB, text/plain)
2011-04-26 12:14 UTC, Diego Elio Pettenò (RETIRED)
Details
ccs-tools-1.8.0_as_needed_fix.patch (ccs-tools-1.8.0_as_needed_fix.patch,362 bytes, patch)
2011-09-27 00:34 UTC, thomasg
Details | Diff
ccs-tools-1.8.0_cleaner_sed.patch (ccs-tools-1.8.0_cleaner_sed.patch,457 bytes, patch)
2011-09-27 00:37 UTC, thomasg
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2011-04-26 12:14:09 UTC
Created attachment 271213 [details]
Build log

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 thomasg 2011-09-27 00:34:34 UTC
Created attachment 287847 [details, diff]
ccs-tools-1.8.0_as_needed_fix.patch

The attached patch fixes this bug by working around the upstream Makefile bug using sed.
As the newest versions also suffer from this, I will report it to upstream as soon I find the appropriate place.
Comment 2 thomasg 2011-09-27 00:37:57 UTC
Created attachment 287849 [details, diff]
ccs-tools-1.8.0_cleaner_sed.patch

This second patch builds upon the bugfix patch, but is completely unrelated to this bug.
It is merely an optical improvement without functional change; I only post this here so it could be included in a revision bump without additional hassle.

It will replace two sed calls by a all-around more clean one.
Comment 3 Naohiro Aota gentoo-dev 2011-09-29 21:53:16 UTC
Fixed in CVS. Thanks!