Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 362431 - sys-fs/zfs-fuse-0.7.0 w/ lzo-patch(es)
Summary: sys-fs/zfs-fuse-0.7.0 w/ lzo-patch(es)
Status: RESOLVED DUPLICATE of bug 358697
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Christian Parpart (RETIRED)
URL: http://zfs-fuse.net/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 11:12 UTC by Stefan G. Weichinger
Modified: 2011-05-02 22:02 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to apply to current zfs-fuse-0.6.9-r1.ebuild (in portage) (diff-0.6.9-r1_to_0.7.1_beta2.patch,4.42 KB, patch)
2011-04-07 11:15 UTC, Stefan G. Weichinger
Details | Diff
diff between 0.6.9-r1 and zfs-fuse-9999.ebuild (newpatch,4.34 KB, patch)
2011-04-09 08:55 UTC, Stefan G. Weichinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan G. Weichinger 2011-04-07 11:12:37 UTC
This is a live ebuild pulling in the git-repo of zfs-fuse-developer Emanuel Anne.
The pulled branch "compress" includes patches to add lzo-compression.
In addition I fixed the usage of USE-flag "bash-completion" in my ebuild.

Reproducible: Always

Steps to Reproduce:
1. emerge
2. test lzo-compression
Actual Results:  
-
Comment 1 Stefan G. Weichinger 2011-04-07 11:15:25 UTC
Created attachment 268837 [details, diff]
patch to apply to current zfs-fuse-0.6.9-r1.ebuild (in portage)

apply patch to zfs-fuse-0.6.9-r1.ebuild in portage.
I call my resulting ebuild zfs-fuse-0.7.1_beta2.ebuild here, might be slightly wrong.
Comment 2 Stefan G. Weichinger 2011-04-07 11:17:28 UTC
One more issue:
I also added the patch from bug #332395, with some small changes to make it work
Comment 3 Marcin Mirosław 2011-04-08 14:28:15 UTC
A few thought about ebuild. There is no need to add version of packages in (R)DEPEND if such old packages are not present in tree. You can safely drop all version, leaving packages name (in this case). Are you sure about RDEPEND? Check runtime dependency using ldd /usr/bin/zfs, zpool ... etc. Why do you inherit linux-mod? Zfs-fuse doesn't create any kernel module.
You've got:
EGIT_REPO_URI="http://rainemu.swishparty.co.uk/git/zfs"
EGIT_BRANCH="compress"
inherit git .....

It's ok, but next you run manually "git checkout compress", it makes previous work useless. Pleas look into other live ebuild, there is no need to do manually checkout. If you inherit {git,subversion,bzr...} proper checkout is done automagically by portage.
(BTW ebuild doesn't work for me:
 *    repository:               http://rainemu.swishparty.co.uk/git/zfs
fatal: ambiguous argument 'compress': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions
fatal: Couldn't find remote ref compress
)
EAPI>=2(1?) doesn need "cd ${S}/" at begin of src_functions()

I wonder what do you think about intergations zfs-fuse-0.6.9 from tree, zfs-fuse-0.7.0 (which should be in tree;) ) and your version of zfs-fuse-0.7.0 which uses diffrent sources than upstream (and i repeat again, it's live ebuild, it should have version zfs-fuse-9999). How do you wont to have all this diffrent version in tree, they have the same name (sometimes the same version) but uses diffrent sources?
Mayby it could be better if zfs-fuse have new USE flags "lzma lzo", and fetch proper patch from git to add such funcionality?
Comment 4 Stefan G. Weichinger 2011-04-09 08:54:50 UTC
(In reply to comment #3)

Thanks for all your suggestions, I am not so good in writing ebuilds yet.
I tried to modify my ebuild according to your suggestions, see new patch.
It compiles fine here.
Comment 5 Stefan G. Weichinger 2011-04-09 08:55:48 UTC
Created attachment 269119 [details, diff]
diff between 0.6.9-r1 and zfs-fuse-9999.ebuild
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2011-04-24 15:07:55 UTC
Not sure why there are 2 separate bugs for zfs-fuse-0.7.0 and futhermore the attached diff breaks the current ebuild in so many levels starting with coding style and dependencies to the install phase.

*** This bug has been marked as a duplicate of bug 358697 ***
Comment 7 Stefan G. Weichinger 2011-05-02 22:02:09 UTC
(In reply to comment #6)
> Not sure why there are 2 separate bugs for zfs-fuse-0.7.0 and futhermore the
> attached diff breaks the current ebuild in so many levels starting with coding
> style and dependencies to the install phase.
> 
> *** This bug has been marked as a duplicate of bug 358697 ***

The diff in here is not relating to stable upstream 0.7.0 but to another repo by one of the main devs of zfs-fuse. The main reason for this was to provide access to the new functionality: lzo-compression. I just copied and modified an older ebuild, so pls forgive any shortcomings. As mentioned before I am not very good yet at writing ebuilds, I just wanted to give some input to keep things close to upstream and call in more experienced devs to have a closer look. Stefan