Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 335159 - net-misc/rdate does not respect LDFLAGS
Summary: net-misc/rdate does not respect LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: ldflags
  Show dependency tree
 
Reported: 2010-08-29 22:19 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2013-03-02 18:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---
robbat2: Bugday+


Attachments
Build log (rdate-1.4-r3:20100829-210000.log,1.47 KB, text/plain)
2010-08-29 22:19 UTC, Diego Elio Pettenò (RETIRED)
Details
Patch to rdate-1.4-r3.ebuild to address LDFLAGS and do general cleanup (rdate-1.4-r3.ebuild.patch,1.12 KB, patch)
2010-08-29 22:57 UTC, Kevin Pyle
Details | Diff
updated ebuild (rdate-1.4-r4.ebuild,916 bytes, text/plain)
2013-03-02 17:24 UTC, Michael Mair-Keimberger (mm1ke)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-29 22:19:17 UTC
See attached build log.

(Please do not complain about the need for looking at the build log until you can provide an easy way to open bugs with the correct data picked out of a tinderbox log. Thanks.)
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-29 22:19:29 UTC
Created attachment 245272 [details]
Build log
Comment 2 Kevin Pyle 2010-08-29 22:57:48 UTC
Created attachment 245279 [details, diff]
Patch to rdate-1.4-r3.ebuild to address LDFLAGS and do general cleanup

This patch makes the following changes:

- Drop assignment of CFLAGS, so that emake does not need to provide an override.
- Drop rule for building rdate, so that the more comprehensive builtin rule applies.  The explicit rule did not use $LDFLAGS, but the implicit rule does.
- Fix install to be $DESTDIR aware, so that the prefix-override hack used in src_install can be removed.
- Use tc-export CC, so that cross-compilation works.
- Drop unnecessary -j1 in emake install.
Comment 3 Michael Mair-Keimberger (mm1ke) 2013-03-02 17:24:08 UTC
Created attachment 340780 [details]
updated ebuild

Updated ebuild (with an slightly modified patch from Kevin Pyle included) for rdate which bumps it to eapi 5.
Comment 4 Aaron W. Swenson gentoo-dev 2013-03-02 18:18:22 UTC
*rdate-1.4-r4 (02 Mar 2013)

  02 Mar 2013; Aaron W. Swenson <titanofold@gentoo.org>
  -files/rdate-initd-1.4-r2, +rdate-1.4-r4.ebuild, -files/rdate-initd:
  Fix bug 335159. Thanks Kevin Pyle and Michael Mair-Keimberger. Clean out
  cruft.