dmenu 4.1.1 has been released a day ago, thus requesting a version bump :). Might it be possible to add these patches? See http://tools.suckless.org/dmenu/patches/ I guess it would be handy by patching them per USE-flags. Reproducible: Always Steps to Reproduce: 1. Always
Created attachment 234535 [details, diff] dmenu-4.1.1 ebuild (patch for dmenu-4.0.ebuild) As I read on the suckless web page, the following patches have been applied to dmenu-4.1.1: - cursor - paste - vertical I'm not sure whether it's reasonable to apply the other patches using USE-flags. What do you think? I created a ebuild for dmenu-4.1.1 with an additional "cpath" USE-flag (don't know whether this is a good name tho) which will pull, compile and add the dmenu_path replacement written in C (see http://tools.suckless.org/dmenu/patches/dmenu_path). The dmenu_path rewrite is "supposedly around 2-4 times faster on cache hits and around 10-20 times faster on cache misses", as stated on the suckless website. So I thought it would be a good idea to add a USE-flag for it. I've tested this ebuild on my amd64 machine, and it seems to work properly. Maybe you can use it somehow, at least I hope :)
Created attachment 235241 [details, diff] Patch against dmenu-4.0.ebuild, added the dependency to sselp I've been using dmenu-4.1.1 in the last few days and I noticed that dmenu-4.1.1 depends on x11-misc/sselp, although there's no note on its dedicated website: dmenu.c:454 if(!(fp = (FILE*)popen("sselp", "r"))) I created a new patch against dmenu-4.0.ebuild including the dependency to sselp. I'm still not sure whether this is a good way on how to add & compile the dmenu_path C rewrite; please correct it if possible :)
I have created a keyword request for ssel. I will report ssel dependency to upstream. I don't want to add external patches because I don't know if there will be maintained or not.
You're right about the patches. Also, it seems like they're already outdated, most of them are for dmenu-4.0 if they weren't included in dmenu-4.1.1 already. But what about dmenu_path.c? It's not really a patch, it just replaces the dmenu_path shell script and thus any modification or version bumps for dmenu don't really depend on dmenu_path.c. But you'll have to decide about that :)
I think it could be a new package for an alternative implementation.
Wouldn't it be overkill to create a new package just because of the dmenu_path script which changes? I guess using a USE-flag would be a slightly better solution.
Hah, I was looking at the cpath replacement as well.
Created attachment 239477 [details, diff] Add sselp dependency, cpath replacement Actually 4.1.1 is in the tree since early July (my fault). This patch adds the sselp dependency (which I happen to maintain) and the "cpath" replacement. Btw, I haven't seen any problem with sselp missing (when it wasn't installed). And indeed, if sselp can't be popen'd then Mod1+p is simply ignored (and the clipboard entry isn't pasted).
There is a main issue to include this patch. It is that dmenu_path.c is not versioned.
Indeed this is a main issue. But there must be a clean way to include this patch, omitting it isn't very nice. Maybe we should ask them to version it? I don't think it would make a big difference, but then at least there's some control over it. As for sselp, wouldn't it be reasonable to include the dependency per USE-flag and (maybe) patch dmenu to remove the pasting feature? But well, it's up to you guys ;)
It's no problem if you consider that it's 7 kilobytes, so a versioned file could easily be placed in FILESDIR. Of course that would require a slight change to my ebuild patch...
Created attachment 239581 [details, diff] revision bump Put a version dmenu_path.c in FILESDIR, mention sselp in einfo but don't RDEPEND on it.
Hi, have you considered using the libXft support patch from http://aur.archlinux.org/packages.php?ID=28745 ? The patch is http://z.ip.fi/~henkka/dmenu-xft/dmenu-4.1.1-3-xft.diff --- /usr/portage/x11-misc/dmenu/dmenu-4.1.1.ebuild 2010-07-17 13:07:39.000000000 +0200 +++ dmenu-4.1.1-r1.ebuild 2010-08-10 01:04:59.000000000 +0200 @@ -4,7 +4,7 @@ EAPI="2" -inherit savedconfig toolchain-funcs +inherit eutils savedconfig toolchain-funcs DESCRIPTION="a generic, highly customizable, and efficient menu for the X Window System" HOMEPAGE="http://www.suckless.org/programs/dmenu.html" @@ -13,13 +13,18 @@ LICENSE="MIT" SLOT="0" KEYWORDS="~amd64 ~hppa ~ppc ~ppc64 ~x86 ~x86-fbsd" -IUSE="xinerama" +IUSE="xft xinerama" DEPEND="x11-libs/libX11 + x11-libs/libXft xinerama? ( x11-libs/libXinerama )" RDEPEND=${DEPEND} src_prepare() { + if use xft ; then + epatch "${FILESDIR}"/${P}-3-xft.diff + fi + sed -i \ -e "s/CFLAGS = -std=c99 -pedantic -Wall -Os/CFLAGS += -std=c99 -pedantic -Wall -g/" \ -e "s/LDFLAGS = -s/LDFLAGS += -g/" \ to be seen at http://svn.xmw.de/websvn/gentoo-overlay/x11-misc/dmenu/
Adding the libXft patch is a really nice idea. However, the x11-libs/libXft dependency should be triggered by the USE flag: xft? ( x11-libs/libXft ) Btw, there's a ongoing discussing in the suckless mailing list about the libXft patch (might be interesting): http://lists.suckless.org/dev/1009/5855.html
Created attachment 249130 [details, diff] Patch for dmenu-4.1.1.ebuild, adding USE flags cpath, xft and paste I modified some more lines in the 4.1.1 ebuild and added the USE flags paste (support for sselp) and xft. The XFT patch and dmenu_path.c file are now versioned, but I have no idea whether this is the correct/clean way to do it. To me this seems the best way to give the user as much choices as possible. Maybe someone could review the patch?
Looks cool, you need to specify LDFLAGS, i've added this versions to my repo at http://svn.xmw.de/websvn/gentoo-overlay/ +++ dmenu-4.1.1-r2.ebuild @@ -55,7 +55,7 @@ if use cpath; then rm -f dmenu_path $(tc-getCC) -w -o dmenu_path "${DMENU_PATH_C}" \ - || die "${DMENU_PATH_C} make failed" + ${LDFLAGS} || die fi }
Created attachment 253649 [details] dmenu-9999.ebuild, builds latest tip from the dmenu repository I made a dmenu ebuild which builds the latest tip from the official repository. As I noticed a lot of things have changed. Some important changes compared to dmenu 4.1.1: - dmenu now uses libdc (see http://bugs.gentoo.org/show_bug.cgi?id=344705) - config.h is gone (http://hg.suckless.org/dmenu/rev/a527f3516a8d) - the dmenu_path C rewrite now replaces the shell script (http://hg.suckless.org/dmenu/rev/69fbc9d47026) I removed the xft patch, since it isn't compatible with the current sources, of course. The cpath USE-flag is now gone too, of course. Enhancements for the ebuild are welcome.
Created attachment 254077 [details, diff] builds latest tip without libdc dependency, patch for dmenu-9999.ebuild It's quite funny, because it seems like the dependency to libdc has been removed in the latest tip of dmenu (see http://www.imdb.com/title/tt0489018/). Dmenu now additionally has the files draw.c and draw.h, which basically contain the required code from libdc as far as I know ... I created a patch for dmenu-9999.ebuild, which builds latest tip without libdc dependency. Maybe there's someone who needs it :).
4.2.1 is out there, presumably including everything that was proposed as patches here.
Created attachment 255211 [details] Ebuild for dmenu-4.2.1 I made an ebuild for dmenu-4.2.1, maybe you can use it. Improvements/suggestions are welcome. By the way, there's some discussion about a new XFT-patch (see http://lists.suckless.org/dev/1011/index.html#6449). I'd really like a patch to be included for dmenu-4.2.1 (although I wouldn't use XFT anyway). If they ever add XFT support, I hope there'll be a way to remove it during compile time.
Fix in CVS
I don't think that the patch discussion is RESO/FIX'ed. Any comment?
(In reply to comment #22) > I don't think that the patch discussion is RESO/FIX'ed. Any comment? > cpath is included in the version bump
(In reply to comment #23) > cpath is included in the version bump sry, my fault. i was disappointed about the not included Xft patch (I check if the old on sill applies).
