Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 320059 - sys-kernel/genkernel-3.4.10.907 TODO: Add all options to genkernel.conf
Summary: sys-kernel/genkernel-3.4.10.907 TODO: Add all options to genkernel.conf
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 321379
  Show dependency tree
 
Reported: 2010-05-16 21:47 UTC by John R. Graham
Modified: 2019-03-26 08:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch implements the described enhancements. (genkernel-3.4.10.907-options-to-genkernel-conf.patch,21.69 KB, patch)
2010-05-16 21:49 UTC, John R. Graham
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John R. Graham gentoo-dev 2010-05-16 21:47:49 UTC
...is now done.  The following command line options now have been added to the common configuration file / arch default mechanism:
  --gconfig
  --xconfig
  --gensplash
  --splash
  --callback
  --tempdir
  --arch-override
  --color
  --genzimage

The man page has also been updated where descriptions of these new commands
were not already present.  I believe a comprehensive pass still needs to be
made through the man page source to make sure it accurately reflects the
current state of the code.  Perhaps another day.

Additional small tweaks:
 - Added a HOWTO guide on adding config file & arch defaulted command line
   options in the comments in gen_cmdline.sh.
 - Corrected typo-level bug in --utils-arch command processing.
 - Corrected typo-level bug in -j argument substitution in "make menuconfig/
   gconfig/xconfig" execution.
 - Added a --no-disklabel command line option to balance --disklabel.
 - Refactored the MENUCONFIG config file option to take the values
   "no", "menuconfig", "gconfig", or "xconfig".  The respective command
   line options alter and override the state of this single configuration
   variable.

That last is the only thing I'm not completely satisfied with.  If you all
have a better idea, let me know and I'll do it.

- John
Comment 1 John R. Graham gentoo-dev 2010-05-16 21:49:51 UTC
Created attachment 231725 [details, diff]
Patch implements the described enhancements.
Comment 2 John R. Graham gentoo-dev 2010-05-16 21:52:40 UTC
Almost forgot.  This patch was made against genkernel-9999, git commit f3e0797d42ff2e0a9066a6364b1e063da9679651.  I'm not really familiar with git; it that the right way to identify the revision?

- John
Comment 3 Sebastian Pipping gentoo-dev 2011-01-05 23:05:12 UTC
PS: Adding keyword "Inclusion" and "[patch] " prefix to better show this bug's nature in searches...
Comment 4 John R. Graham gentoo-dev 2011-05-17 18:49:19 UTC
Sebastian, would it help if I refactored this code to apply correctly to the current tip revision?

- John
Comment 5 Sebastian Pipping gentoo-dev 2011-05-17 18:53:58 UTC
(In reply to comment #4)
> Sebastian, would it help if I refactored this code to apply correctly to the
> current tip revision?

Yes.  That would be master on git://git.overlays.gentoo.org/proj/genkernel.git .

Thanks!
Comment 6 Sebastian Pipping gentoo-dev 2011-06-13 21:25:46 UTC
PS: It looks like the patch does many small things in one patch.
Please make many small dedicated patches for us, explaining your intention in the commit log of each patch ideally.  With many small patches it's not going to be fun attaching all of them here.  I propose to get a git repo hosted somewhere and send us a link to that once you have the patches ready for a first round of review.  If that goes well I would love to integrate you further into genkernel as you see fits.  If you have anything to discuss outside of this bug please contact us at genkernel@g.o.
Comment 7 John R. Graham gentoo-dev 2011-06-14 14:11:04 UTC
Sebastian,

I'll do that if that's what it takes. My view was that the patch didn't do many small things but did one big thing: make all genkernel options expressible on the command line and in the config file with reasonable defaults.

I added the configuration defaulting / command line vs. config file resolution code to genkernel to begin with; I was just bring it up to date after about 18 months of drift. The HOWTO expressed in comments in the code was my attempt to reduce future drift.

Now, that said, unless I hear different, I'll proceed as you recommend.

- John
Comment 8 Sebastian Pipping gentoo-dev 2011-06-14 16:59:10 UTC
> I'll do that if that's what it takes. My view was that the patch didn't do many
> small things but did one big thing: make all genkernel options expressible on
> the command line and in the config file with reasonable defaults.

Maybe it's a question of view.  From a quick scan over your latest patch I see:
- a bugfix (DEBUGFILE versus LOGFILE, fixed by now)
- changes related to CMD_ABC versus ABC
- unification of menuconfig/gconfig/xconfig
- move of initialization of variable TEMP
- adding support for new parameters/options
- adding in-code documentation (which is nice!)
- possibly more

For a person reviewing this, many small patches would be
easier to review and allow following your thinking better.
At best we fully understand what you did - that's a long way.

PS: In case you want to avoid setting up a hosted git repo somewhere, we could also give limited push access to the genkernel repo to you.  Limited means that
you can push commits to a branch "graham" (or so) only.  If that sounds interesting, please mail an SSH pubkey of yours to genkernel@g.o.
Comment 9 John R. Graham gentoo-dev 2011-06-14 20:20:44 UTC
Understood. They are all related to command line parsing / configuration file / architecture defaulting, but points taken. Although setting up an external git repository would be fun, I'll take you up on your kind "limited push" access offer, as my goal right now is to contribute to genkernel.

I'll send you my home developer box ssh key when I get home this evening. (Cisco stingily doesn't let me tunnel to it from work.)

- John
Comment 10 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-01-24 05:55:17 UTC
@John R. Graham:
it's very difficult to tell which of these changes was already handled in a different way or otherwise obsolete.

Esp as the config handling and manpage have changed dramatically since you wrote the patch.

Could you please review and respin for any pieces you think are still needed?

If there is no response in a few months, i'll close with RESO:NEEDINFO
Comment 11 John R. Graham gentoo-dev 2017-02-14 15:42:50 UTC
Robin, will do. It'll probably take me 'til end of March, though.
Comment 12 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-07-14 19:30:51 UTC
reping
Comment 13 Thomas Deutschmann gentoo-dev Security 2019-03-26 08:43:19 UTC
I am closing this bug as obsolete:

- Patch no longer applies (heh, patch is from 2010...)

- man page, help and genkernel.conf is now in sync.

Let's open a new bug is something is missing.