Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 321379 - [patch] sys-kernel/genkernel-3.4.10.907: Nice New Feature
Summary: [patch] sys-kernel/genkernel-3.4.10.907: Nice New Feature
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: Inclusion
Depends on: 320059
Blocks:
  Show dependency tree
 
Reported: 2010-05-25 00:57 UTC by John R. Graham
Modified: 2016-01-24 05:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch implements the described enhancements. (genkernel-3.4.10.907-nice-option.patch,7.26 KB, patch)
2010-05-25 01:12 UTC, John R. Graham
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John R. Graham gentoo-dev 2010-05-25 00:57:19 UTC
I've always wanted an option for genkernel that is roughly equivalent to the PORTAGE_NICENESS variable in /etc/make.conf that affects the priority of the kernel make, so here it is.  In keeping with genkernel's command line philosophy of allowing almost anything that can be put in the config file to be overridden on the command line, I created a --nice command line option that can take three forms:
  --nice     Specifies a default niceness level of 10.
  --nice=n   Specifies a niceness level 0 - 19.
  --no-nice  Runs kernel make at full user priority.

There's a corresponding genkernel.conf option named NICE that specifies the niceness level in the absence of a command line override.

The man page has also been updated to include the new commands.  I also found and corrected some inconsistent boldfacing in the sub-headings.

Finally, I did some minor cruft removal and style tweaks in genkernel.

- John
Comment 1 John R. Graham gentoo-dev 2010-05-25 01:00:14 UTC
This patch is additive to the enhancement patch I submitted in bug #320059.

- John
Comment 2 John R. Graham gentoo-dev 2010-05-25 01:12:18 UTC
Created attachment 232801 [details, diff]
Patch implements the described enhancements.

And here's the patch.

- John
Comment 3 Sebastian Pipping gentoo-dev 2011-01-05 23:05:25 UTC
PS: Adding keyword "Inclusion" and "[patch] " prefix to better show this bug's nature in searches...
Comment 4 Sebastian Pipping gentoo-dev 2011-01-11 11:27:21 UTC
John, are you still interested in getting this patch applied?
What advantages do you see over putting the whole genkernel process behind nice?
Comment 5 John R. Graham gentoo-dev 2011-01-11 23:47:29 UTC
Yes I would. Although I see your point, I think of it as a useful configuration default.
Comment 6 Patrick Lauer gentoo-dev 2016-01-20 14:12:19 UTC
(In reply to Sebastian Pipping from comment #4)
> John, are you still interested in getting this patch applied?
> What advantages do you see over putting the whole genkernel process behind
> nice?

Advantage: I don't need to worry, genkernel will do the right thing and run niced, even if I'm a forgetful person.

I would like to have this feature, I've found it difficult to balance the amount of threads vs. system load, niceness is a lot easier to calibrate.
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-01-24 05:55:50 UTC
This is merged in master Git now.