Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 317369 - Two patches to make sys-fs/vhba compile with kernels >=2.6.34-rc3 (back
Summary: Two patches to make sys-fs/vhba compile with kernels >=2.6.34-rc3 (back
Status: RESOLVED DUPLICATE of bug 317119
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Highest major (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-26 20:15 UTC by Francis Galiegue
Modified: 2010-04-30 07:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
First upstream patch (URL in the patch file) (0001-Remove-include-linux-autoconf.h-from-kat-tests.patch,1.30 KB, text/plain)
2010-04-26 20:26 UTC, Francis Galiegue
Details
Second upstream patch (URL in the patch file) (0002-vhba.c-explicitly-include-linux-slab.h.patch,1.29 KB, text/plain)
2010-04-26 20:27 UTC, Francis Galiegue
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francis Galiegue 2010-04-26 20:15:37 UTC
RATIONALE:

*/cdemu* are very useful end user packages allowing one to mount various CD image formats to emulated SCSI CDROM/DVD devices easily. Both rely on sys-fs/vhba, which is a compiled-in kernel module.

Unfortunately, with 2.6.33+, the module, as of 1.2.1 (which is the current version in ~amd64) doesn't compile at all. Two reasons for this:

* #include <linux/autoconf.h> raises definition conflicts, and leads to a wrong kernel.api.h;
* starting with 2.6.34-rc3, <linux/slab.h> MUST be included so that kmalloc() and friends (plus kfree()) be defined, and the base CPPFLAGS for kat/Makefile include -Werror-implicit-function-declaration.

Two patches are included, both are upstream (the second one came from me initially, even though the upstream message doesn't reflect it):

* the first one removes all includes of <linux/autoconf.h> from kat/*.c;
* the second one #includes <linux/slab.h> in vhba.c.

Please consider adding these two patches and make a 1.2.1-r1 version of this module: this will guarantee correct compilation of this module for some time to come.

Patches follow.
Comment 1 Francis Galiegue 2010-04-26 20:26:46 UTC
Created attachment 229313 [details]
First upstream patch (URL in the patch file)
Comment 2 Francis Galiegue 2010-04-26 20:27:16 UTC
Created attachment 229315 [details]
Second upstream patch (URL in the patch file)
Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-04-30 07:44:03 UTC
Already in cvs bug 317119 and bug 303146

  26 Apr 2010; Peter Volkov (pva)
  +files/vhba-1.2.1-kernel-2.6.34.patch:
  Fixed build issue with 2.6.34 kernels, bug #317119, thank Rion for report.

  05 Mar 2010; Peter Volkov (pva) vhba-1.2.1.ebuild,
  +files/vhba-1.2.1-kernel-2.6.33.patch:
  Added patch to fix compatibility with 2.6.33 kernels, bug 303146 thank
  Rion for catching upstream fix fast.

*** This bug has been marked as a duplicate of bug 317119 ***