Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 312743 - gpe-base/gpe-login hard codes incorrect min UID/GID for valid users
Summary: gpe-base/gpe-login hard codes incorrect min UID/GID for valid users
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Yuri Vasilevski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 309409
  Show dependency tree
 
Reported: 2010-04-02 04:00 UTC by Yuri Vasilevski (RETIRED)
Modified: 2010-07-23 11:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gpe-login-min-uid.patch (gpe-login-uid.patch,2.23 KB, patch)
2010-04-02 04:02 UTC, Yuri Vasilevski (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Vasilevski (RETIRED) gentoo-dev 2010-04-02 04:00:38 UTC
gpe-base/gpe-login has hard coded min UID for users to he considered as valid/real users to 100, which works for many systems but in Gentoo we start valid/real users with UID of 1000 and GID of 1000.

The proposed patch adds ./configure switches --with-min-valid-uid=N and --with-min-valid-gid=N that allows tunning the UID and GID values during compilation (defaulting to 100/100).

This fixes the display of only valid/real users during in the combobox during login, as well as, makes gpe-login add new users with the right UID and GID.

Assigning to myself and waiting gpe-login maintainer's comments for commit.

Reproducible: Always
Comment 1 Yuri Vasilevski (RETIRED) gentoo-dev 2010-04-02 04:02:06 UTC
Created attachment 226217 [details, diff]
gpe-login-min-uid.patch
Comment 2 Angelo Arrifano (RETIRED) gentoo-dev 2010-04-02 10:03:25 UTC
(In reply to comment #0)
> gpe-base/gpe-login has hard coded min UID for users to he considered as
> valid/real users to 100, which works for many systems but in Gentoo we start
> valid/real users with UID of 1000 and GID of 1000.
> 
> The proposed patch adds ./configure switches --with-min-valid-uid=N and
> --with-min-valid-gid=N that allows tunning the UID and GID values during
> compilation (defaulting to 100/100).

Looks good. I'm going to point out this bug to upstream.

> 
> This fixes the display of only valid/real users during in the combobox during
> login, as well as, makes gpe-login add new users with the right UID and GID.
> 
> Assigning to myself and waiting gpe-login maintainer's comments for commit.
Those hardcoded IDs were definitely not the way to go in Gentoo. Thanks for reporting and fixing.

> 
> Reproducible: Always
> 

Comment 3 Yuri Vasilevski (RETIRED) gentoo-dev 2010-04-02 13:47:10 UTC
> Looks good. I'm going to point out this bug to upstream.

Already pinged upstream (Philip Blundell) on this bug, lets hope he responds quickly.
Comment 4 Angelo Arrifano (RETIRED) gentoo-dev 2010-07-23 11:47:53 UTC
Patch committed to CVS.

Upstream says they are going to include this in next version bump. So, we will use this patch until new version is out.