Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301161 - net-irc/xchat-2.8.6-r2 uses gtkspell causing large input box
Summary: net-irc/xchat-2.8.6-r2 uses gtkspell causing large input box
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Packages in net-irc
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-16 04:23 UTC by s0ulslack
Modified: 2010-07-29 13:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
smaller input box (xchat-input-box.patch,1.36 KB, patch)
2010-02-24 13:30 UTC, Rafał Mużyło
Details | Diff
new version of the old patch (xchat-input-box3.patch,1.37 KB, patch)
2010-07-20 22:30 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description s0ulslack 2010-01-16 04:23:47 UTC
Bug #259442 is closed, not sure why.  When compiling with --enable-spell=gtkspell, you receive the warning "Warning: GTK SPELL is not the recommended spelling library." So why are we using it by default?  As noted in #259442 and #246138 it causes a rather large and ugly input box.

Please revert the change!

Reproducible: Always
Comment 1 Rafał Mużyło 2010-02-24 13:30:01 UTC
Created attachment 220973 [details, diff]
smaller input box

One of the better answers to such report is: "the beauty is in
the eye of the beholder".

But as for the size, it seems to be caused by incorrect widget
packing. See if this patch works correctly for you.
Comment 2 s0ulslack 2010-02-24 20:17:50 UTC
There needs to be a way to use libsexy, not just one method that the program warns is DEPRECIATED.  Gentoo has got terrible in the last years, damn.
Comment 3 Rafał Mużyło 2010-02-24 22:05:58 UTC
Please, don't whine.
I doubt gtkspell is deprecated - it's libsexy that seems 
dead upstream. It's more like xchat upstream didn't get the input
box size right and blamed it on GtkTextView widget.
Comment 4 Serkan Kaba (RETIRED) gentoo-dev 2010-04-08 18:04:32 UTC
As explained in bug #246138 sexyspell edit is *borked* in segmenting non-ascii text. That's why we stick with gtkspell
Comment 5 Rafał Mużyło 2010-07-20 22:30:15 UTC
Created attachment 239609 [details, diff]
new version of the old patch

Minor detail polished, I think as good as it gets without more intrusive changes.
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-07-21 00:59:47 UTC
+  21 Jul 2010; Lars Wendler <polynomial-c@gentoo.org>
+  +files/xchat-input-box3.patch, xchat-2.8.8.ebuild:
+  Added a patch to make the input box a bit smaller. Thanks to s0ulslack for
+  reporting this in bug #301161 and to Rafał Mużyło for the patch.
+

Fixed in 2.8.8 without a revbump. So if you want to have the smaller input box, re-emerge xchat.
Comment 7 Rafał Mużyło 2010-07-29 13:33:05 UTC
Just a note for people coming here through SourceForge tracker
- see bug 330007 for a corrected patch.