Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 330007 - net-irc/xchat-2.8.8 channel status dot in wrong place
Summary: net-irc/xchat-2.8.8 channel status dot in wrong place
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-27 00:25 UTC by Westly Ward
Modified: 2010-07-28 11:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
screenshot (Screenshot-XChat.png,160.79 KB, image/png)
2010-07-27 00:30 UTC, Jeroen Roovers (RETIRED)
Details
fixed patch (xchat-input-box4.patch,1.09 KB, patch)
2010-07-27 13:57 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Westly Ward 2010-07-27 00:25:33 UTC
When running xchat 2.8.8 with the most recent patch, IE the one that fixes the input bar height, the status dot is above the nick, when it should be to the left.  Screenshot at http://dl.dropbox.com/u/1614806/Screenshot-XChat.png
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-27 00:30:36 UTC
Created attachment 240247 [details]
screenshot

(In reply to comment #0)
> Screenshot at http://dl.dropbox.com/u/1614806/Screenshot-XChat.png

Please just attach the file next time instead of relying on external resources.
Comment 2 Westly Ward 2010-07-27 00:44:45 UTC
(In reply to comment #1)
> Created an attachment (id=240247) [details]
> screenshot
> 
> (In reply to comment #0)
> > Screenshot at http://dl.dropbox.com/u/1614806/Screenshot-XChat.png
> 
> Please just attach the file next time instead of relying on external resources.
> 

Sorry, I didn't see any attach button until after I had posted it
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-07-27 01:48:57 UTC
Rafał you wrote the patch. Can you fix the problem?
Comment 4 Rafał Mużyło 2010-07-27 02:40:29 UTC
Well, it may take awhile - I've never saw that dot myself.
Is that the channel op marker ?
Comment 5 Rafał Mużyło 2010-07-27 13:57:27 UTC
Created attachment 240321 [details, diff]
fixed patch

OK, I think I've got it.
Seems that I didn't need to change one of the lines.
Frankly, the original patch is so old, that I no longer recall,
why did the change seemed needed back then.
Comment 6 Westly Ward 2010-07-27 16:47:21 UTC
(In reply to comment #5)
> Created an attachment (id=240321) [details]
> fixed patch
> 
> OK, I think I've got it.
> Seems that I didn't need to change one of the lines.
> Frankly, the original patch is so old, that I no longer recall,
> why did the change seemed needed back then.
> 

Ok, I replaced the old patch with this patch and now everything seems to be fixed.  Thanks for the help.  One question I have is, will this ever get into the main branch of portage?
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-07-28 11:17:25 UTC
(In reply to comment #6)
> One question I have is, will this ever get into
> the main branch of portage?
> 

Lemme give this patch another testing and when I'm content with the result I will replace the old patch with this one.
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2010-07-28 11:28:36 UTC
+  28 Jul 2010; Lars Wendler <polynomial-c@gentoo.org>
+  -files/xchat-input-box3.patch, xchat-2.8.8.ebuild,
+  +files/xchat-input-box4.patch:
+  Fixed placement of channelstatus dot at the left side of the input box.
+  Thanks to Westly Ward for reporting this issue in bug #330007 and Rafał
+  Mużyło for providing a fixed patch.
+

I've fixed this without revision bump.