Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 295986 - patch media-libs/libdvdread-4.1.3_p1168 for compatibility with dvdbackup-0.4.1
Summary: patch media-libs/libdvdread-4.1.3_p1168 for compatibility with dvdbackup-0.4.1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-06 16:25 UTC by Torsten Kurbad
Modified: 2010-03-17 15:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
libdvdread-4.1.3_p1168.ebuild.patch (libdvdread-4.1.3_p1168.ebuild.patch,386 bytes, patch)
2009-12-06 16:26 UTC, Torsten Kurbad
Details | Diff
libdvdread-4.1.3_p1168-DVDFileStat.patch (libdvdread-4.1.3_p1168-DVDFileStat.patch,6.75 KB, patch)
2009-12-06 16:27 UTC, Torsten Kurbad
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kurbad 2009-12-06 16:25:57 UTC
In bug #235712, user davide attached an ebuild for media-video/dvdbackup-0.4.1.

This doesn't work out of the box with newer versions (i.e. >=4.1.3) of media-libs/libdvdread. http://dvdbackup.sourceforge.net/ hosts a patch to re-add the removed DVDFileStat functions to libdvdread-4.1.3. However, this patch needed slight modifications for 4.1.3_p1168. Find attached a diff to the current media-libs/libdvdread-4.1.3_p1168.ebuild and a working patch derived from the one on the dvdbackup site. Since it doesn't change functionality, but only adds some functions to the library, it shouldn't break compatibility to any other packages.

Can this be included by default and the dvdbackup ebuild from bug #235712 finally added to portage?

Best regards
Torsten

Reproducible: Always

Steps to Reproduce:
Comment 1 Torsten Kurbad 2009-12-06 16:26:50 UTC
Created attachment 212239 [details, diff]
libdvdread-4.1.3_p1168.ebuild.patch
Comment 2 Torsten Kurbad 2009-12-06 16:27:39 UTC
Created attachment 212241 [details, diff]
libdvdread-4.1.3_p1168-DVDFileStat.patch
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-12-08 10:35:43 UTC
It might be just me, but that sounds very wrong. 

How long are we supposed to carry this patch in libdvdread around until this application (dvdbackup) which isn't even in Portage will work without them?

I think your options are:

a) convince mplayer devs to re-add the functions to libdvdread
or b) patch dvdbackup to work without these functions from libdvdread

I'd go with b)
Comment 4 Torsten Kurbad 2009-12-08 10:59:06 UTC
(In reply to comment #3)
> I'd go with b)

That sounds reasonable. Anyhow, my knowledge of C is much less than sufficient to accomplish such patching...

Any volunteers? ;-)
Comment 5 Torsten Kurbad 2009-12-08 14:14:40 UTC
Update: I asked the dvdbackup developers about the possibilities of adapting to different versions of libdvdread.

See https://answers.launchpad.net/dvdbackup/+question/93323
Comment 6 Jacek Sowiński 2009-12-30 21:32:26 UTC
(In reply to comment #5)
> Update: I asked the dvdbackup developers about the possibilities of adapting to
> different versions of libdvdread.
> 
> See https://answers.launchpad.net/dvdbackup/+question/93323
> 

I've found this on launchpad:
„This question was expired because it remained in the 'Open' state without activity for the last 15 days.”

Maybe just fill it as a bug there?
Comment 7 Ben de Groot (RETIRED) gentoo-dev 2010-03-17 15:28:43 UTC
This should be taken upstream. It is not something we want to fix locally (meaning in Gentoo only).