Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 235712 - media-video/dvdbackup-0.4.1 bump request
Summary: media-video/dvdbackup-0.4.1 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-25 19:50 UTC by Tiziano Müller (RETIRED)
Modified: 2010-09-01 19:56 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed NEW ebuild (dvdbackup-0.4.1.ebuild,626 bytes, text/plain)
2009-11-25 18:24 UTC, davide
Details
dvdbackup-0.4.1.ebuild (dvdbackup-0.4.1.ebuild,593 bytes, text/plain)
2010-08-31 16:52 UTC, Daniel Pielmeier
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tiziano Müller (RETIRED) gentoo-dev 2008-08-25 19:50:13 UTC
Updated ebuild can be pulled from my overlay:
http://git.overlays.gentoo.org/gitweb/?p=dev/dev-zero.git;a=tree;f=media-video/dvdbackup;hb=HEAD
Comment 1 Alexis Ballier gentoo-dev 2008-09-07 21:09:54 UTC
homepage is different but this seems an update of the old 0.1.1

please commit it as long as:
- you've tested it
- it doesnt break ripmake's usage of it
- the patches aren't needed anymore

also note that license seems to be gpl-3 now :)
Comment 2 Benjamin Drung 2008-11-29 20:24:26 UTC
dvdbackup 0.2 is a fork of the old 0.1.1, because the project seemed abandoned. For the changes have a look at http://sourceforge.net/project/shownotes.php?group_id=219904&release_id=585785

ripmake usage of dvdbackup should also work with dvdackup 0.2. If there are patched required, please report them upstream.
Comment 3 davide 2009-11-25 18:24:52 UTC
Created attachment 211182 [details]
Proposed NEW ebuild

This "ebuild" work (for me).
Comment 4 Sebastian Pipping gentoo-dev 2010-06-24 16:23:33 UTC
A few things I have stumbled upon needed for a bum to 0.4.1:
- Set license to GPL-3 or later
- Depend on gettext
- Apply patch [1] to dependency libdvdread 4.1.3 or dvdbackup won't build.
  Btw Debian has that patch applied, too.


[1] http://dvdbackup.sourceforge.net/DVDFileStat.patch
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2010-06-24 16:33:04 UTC
(In reply to comment #4)
> A few things I have stumbled upon needed for a bum to 0.4.1:
> - Set license to GPL-3 or later
> - Depend on gettext
> - Apply patch [1] to dependency libdvdread 4.1.3 or dvdbackup won't build.
>   Btw Debian has that patch applied, too.
> 
> 
> [1] http://dvdbackup.sourceforge.net/DVDFileStat.patch
> 

We have already rejected that patch in bug 295986.
Comment 6 Daniel Pielmeier gentoo-dev 2010-08-31 16:52:18 UTC
Created attachment 245511 [details]
dvdbackup-0.4.1.ebuild

The DVDFileStat.patch has been merged upstream [1]. The current libdvdread snapshot is to old, so this ebuild works only with libdvdread-9999.

[1] http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2009-February/000984.html
Comment 7 Sebastian Pipping gentoo-dev 2010-09-01 12:45:08 UTC
(In reply to comment #6)
> The DVDFileStat.patch has been merged upstream [1]. The current libdvdread
> snapshot is to old, so this ebuild works only with libdvdread-9999.

Good finding.  Having a closer look at the moment.
Comment 8 Sebastian Pipping gentoo-dev 2010-09-01 13:18:34 UTC
Bumped in tree, masked for now.

To check it out please unmask

  =media-libs/libdvdread-4.1.3_p1217
  =media-video/dvdbackup-0.4.1

and open bugs as needed.  Closing.
Comment 9 Daniel Pielmeier gentoo-dev 2010-09-01 14:23:08 UTC
(In reply to comment #8)
> Bumped in tree, masked for now.
> 
> To check it out please unmask
> 
>   =media-libs/libdvdread-4.1.3_p1217
>   =media-video/dvdbackup-0.4.1
> 
> and open bugs as needed.  Closing.
> 

Didn't you take a look at the ebuild I have attached? I think it needs gettext (you also suggested this in comment #4) thus the virtual/intltool dependency. What about installing all docs? The way it is now only two of them get installed uncompressed.

SRC_URI also works like I used it as it gets redirected to the proper location. Don't know if this will change though.
Comment 10 Sebastian Pipping gentoo-dev 2010-09-01 19:01:38 UTC
(In reply to comment #9)
> Didn't you take a look at the ebuild I have attached? I think it needs gettext
> (you also suggested this in comment #4) thus the virtual/intltool dependency.

Good catch.  Fixed.


> What about installing all docs? The way it is now only two of them get
> installed uncompressed.

Any suggestions to fix this cleanly?


> SRC_URI also works like I used it as it gets redirected to the proper location.
> Don't know if this will change though.

I'd suggest we take the URI with less redirections.  Which one would that be?  (In a hurry right now.)
Comment 11 Daniel Pielmeier gentoo-dev 2010-09-01 19:48:59 UTC
@@ -11,16 +11,21 @@
 LICENSE="GPL-3"
 SLOT="0"
 KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86 ~amd64-linux ~x86-linux ~ppc-macos ~x86-solaris"
-IUSE=""
+IUSE="nls"
 
 DEPEND=">=media-libs/libdvdread-4.1.3_p1217
-	virtual/libintl"
-RDEPEND="${RDEPEND}"
+	nls? ( virtual/libintl )"
+RDEPEND="${DEPEND}"
 
 src_configure() {
-	econf --docdir="/usr/share/doc/${PF}"
+	econf \
+		$(use_enable nls) \
+		--disable-dependency-tracking \
+		--disable-rpath \
+		--docdir="/usr/share/doc/${PF}"
 }
 
 src_install() {
 	emake DESTDIR="${D}" install || die 'emake install failed'
+	dodoc AUTHORS ChangeLog NEWS README || die 'dodoc failed'
 }

I just made the above changes to the ebuild.

Adding nls use flag. Compiling with USE="nls" and without gettext installed went fine so the libintl virtual should be okay. So only systems without glibc and ulibc need gettext installed.

RDEPEND="${RDEPEND}" this does not make sense I guess so changed it to RDEPEND="${DEPEND}".

Disabled a few configure options.
Comment 12 Daniel Pielmeier gentoo-dev 2010-09-01 19:51:38 UTC
Forgot to mention that NEWS README are installed uncompressed. By adding 
dodoc AUTHORS ChangeLog NEWS README || die 'dodoc failed'
they get overwritten and compressed by dodoc.
Comment 13 Daniel Pielmeier gentoo-dev 2010-09-01 19:56:08 UTC
PS: I don't think this packages should be masked. I have the libdvdread/libdvdnav live ebuilds installed and vlc, transcode, dvdauthor, etc work fine with them.