Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 290639 - [gnome-overlay] dev-libs/gobject-introspection-0.6.5 build fix
Summary: [gnome-overlay] dev-libs/gobject-introspection-0.6.5 build fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 21:29 UTC by Karl Mikaelsson
Modified: 2010-10-02 13:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Attached patch will remove CPPFLAGS from the make rule. (0001-dev-libs-gobject-introspection-Fix-build-problem.patch,3.46 KB, patch)
2009-10-26 21:30 UTC, Karl Mikaelsson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Mikaelsson 2009-10-26 21:29:36 UTC
dev-libs/gobject-introspection-0.6.5: 

gir/Makefile.am includes CPPFLAGS as argument when invoking ../tools/g-ir-scanner in a target. g-ir-scanner does not accept the same range of options as gcc. g-ir-scanner fails pretty bad on something as simple as -march="foo". 

Reproducible: Always

Steps to Reproduce:
1. layman -a gnome
2. CPPFLAGS="-march=native" emerge =dev-libs/gobject-introspection-0.6.5

Actual Results:  
env LPATH=.libs  env PYTHONPATH=..:..:$PYTHONPATH UNINSTALLED_INTROSPECTION_SRCDIR=.. UNINSTALLED_INTROSPECTION_BUILDDIR=.. ../tools/g-ir-scanner -v --add-include-path=../gir --add-include-path=. \
	    --namespace GLib --nsversion=2.0 \
	    --noclosure \
	    --output GLib-2.0.gir \
	    --strip-prefix=g \
	    --libtool="/bin/sh ../libtool" \
	    --c-include="glib.h" \
	    --library=glib-2.0 \
	    --pkg glib-2.0 \
	    -march=native \
	    -I`pkg-config --variable=includedir glib-2.0`/glib-2.0 \
	    -I`pkg-config --variable=libdir glib-2.0`/glib-2.0/include \
	    -DGETTEXT_PACKAGE=Dummy \
	    -D__G_I18N_LIB_H__ \
	    `pkg-config --variable=libdir glib-2.0`/glib-2.0/include/glibconfig.h \
	    ./glib-2.0.c \
	    -DGLIB_COMPILATION \
	    `pkg-config --variable=includedir glib-2.0`/glib-2.0/glib/*.h
Usage: g-ir-scanner [options] sources

g-ir-scanner: error: no such option: -m
make[2]: *** [GLib-2.0.gir] Error 2
make[2]: Leaving directory `/var/tmp/portage/dev-libs/gobject-introspection-0.6.5/work/gobject-introspection-0.6.5/gir'
Comment 1 Karl Mikaelsson 2009-10-26 21:30:15 UTC
Created attachment 208361 [details, diff]
Attached patch will remove CPPFLAGS from the make rule.
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-10-26 21:44:05 UTC
is that even a valid cppflag ? cppflag is for pre-processor right ?
Comment 3 Karl Mikaelsson 2009-10-27 07:06:12 UTC
I was under the expression that it was cflags for c++, but looking into it, it seems that I've been wrong. My gcc manpages are gone, for some reason :-) (I know, bug 256608).

Still, I doubt that g-ir-scanner accepts all arguments that the gcc preprocessor does, so I'd say the patch is still valid.
Comment 4 vp 2010-02-28 01:10:08 UTC
versions up to 0.6.7 still suffer from this problem
Comment 5 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-02-28 07:05:12 UTC
(In reply to comment #3)
> I was under the expression that it was cflags for c++, but looking into it, it
> seems that I've been wrong. My gcc manpages are gone, for some reason :-) (I
> know, bug 256608).
> 

CXXFLAGS --> C++
CPPFLAGS --> Pre-processor

> Still, I doubt that g-ir-scanner accepts all arguments that the gcc
> preprocessor does, so I'd say the patch is still valid.
> 

It would be preferable to get the opinion of upstream on this (aka, please report a bug upstream, thanks).
Comment 6 vp 2010-02-28 11:31:14 UTC
adding CXXFLAGS="" emerge gobject-introspection does fix the problem

i also reported the bug upstream. now just waiting to see if they pick it up.
Comment 7 vp 2010-02-28 16:20:20 UTC
upstream thinks GENTOO should just drop CXXFLAGS. they consider this not a bug

see https://bugzilla.gnome.org/show_bug.cgi?id=611385
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-10-02 13:38:09 UTC
Looks like upstream went back on their comment.

commit fbc86ceae2553996a59e2e96be3c6afcece8fc55
Author: Alexey Zakhlestin <indeyets@gmail.com>
Date:   Fri Jun 4 14:35:24 2010 +0400

    Do not include preprocessor flags into GLib_2_0_gir_CFLAGS
    
    https://bugzilla.gnome.org/show_bug.cgi?id=606686

Afaik, portage has fixed revisions already. Closing fixes. Don't hesitate to reopen if it's not the case. Thanks for reporting.