Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279636 - [patch] sys-auth/consolekit-0.3.0-r1: init script reports false startup error, wrong pidfile
Summary: [patch] sys-auth/consolekit-0.3.0-r1: init script reports false startup error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High major (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 278181
  Show dependency tree
 
Reported: 2009-07-30 00:25 UTC by Michael Weber (RETIRED)
Modified: 2009-09-13 09:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new /etc/init.d script (consolekit,573 bytes, text/plain)
2009-07-30 00:26 UTC, Michael Weber (RETIRED)
Details
difference between old and new /etc/init.d script (patch,327 bytes, patch)
2009-07-30 00:28 UTC, Michael Weber (RETIRED)
Details | Diff
init.diff (init.diff,563 bytes, patch)
2009-09-11 10:57 UTC, Pacho Ramos
Details | Diff
init.diff (init.diff,577 bytes, text/plain)
2009-09-11 11:15 UTC, Pacho Ramos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weber (RETIRED) gentoo-dev 2009-07-30 00:25:19 UTC
The start-stop-deamon does not find console-kit-daemon's pidfile.

Reproducible: Always

Steps to Reproduce:
1. /etc/init.d/consolekit.orig start
Actual Results:  
consolekit.orig   |* Starting ConsoleKit daemon...
consolekit.orig   |* start-stop-daemon: /usr/sbin/console-kit-daemon  [ !! ]
consolekit.orig   |* ERROR: consolekit.orig failed to start

Expected Results:  
consolekit        |* Starting ConsoleKit daemon...  [ ok ]

The deamons pidfile is /var/run/ConsoleKit/pid, which has to be communicated to the start=stop-daemon expecting /var/run/console-kit-daemon.pid or similar.
Diff and new init.d script follows ...
Comment 1 Michael Weber (RETIRED) gentoo-dev 2009-07-30 00:26:32 UTC
Created attachment 199610 [details]
new /etc/init.d script
Comment 2 Michael Weber (RETIRED) gentoo-dev 2009-07-30 00:28:18 UTC
Created attachment 199612 [details, diff]
difference between old and new /etc/init.d script
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-08-31 20:28:25 UTC
an emerge --info would be nice even if it sounds useless for you.
Comment 4 Pacho Ramos gentoo-dev 2009-09-11 10:45:09 UTC
consolekit init.d daemon starts ok for me. Please drop "-q/--quiet" from init.d script for seeing the exact error (in my case, it was failing because there was another consolekit daemon instance already running, the problem is that I still don't know what launched it :-/)
Comment 5 Romain Perier (RETIRED) gentoo-dev 2009-09-11 10:56:42 UTC
Even if the patch is small, a unified diff would be better (diff -u), imho.
Comment 6 Pacho Ramos gentoo-dev 2009-09-11 10:57:15 UTC
Created attachment 203780 [details, diff]
init.diff

OK, this is the patch in unified mode
Comment 7 Pacho Ramos gentoo-dev 2009-09-11 10:59:45 UTC
Seems that there are two problems here:
1. consolekit init.d script is not really working as pidfile is not properly specified, then, "consolekit stop" won't kill it. Provided patches solve this

2. The second problem is that hald launches itself a console-kit-daemon instance, then, if a user manually tries to run:
/etc/init.d/consolekit start

it will fail because another instance is already running :-/
Comment 8 Pacho Ramos gentoo-dev 2009-09-11 11:13:10 UTC
Adding --oknodo should solve that problem also :-/, but, why is hald not starting "consolekit" with its init.d file as hald init.d file has "use consolekit" ?
Comment 9 Pacho Ramos gentoo-dev 2009-09-11 11:15:39 UTC
Created attachment 203783 [details]
init.diff

This should work fine now
Comment 10 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-09-12 18:58:07 UTC
I don't see where the problem should be.

If consolekit is installed at boot, starting hald will start consolekit via "use consolekit", so that hald doesn't have to spawn it's own consolekit process.

If consolekit is not installed at boot, hald can't spawn it manually (since it doesn't exist).

The only problem will come when someone has a HAL install which has an older init.d file, in which case it will go away when they upgrade HAL.
Comment 11 Pacho Ramos gentoo-dev 2009-09-12 19:03:05 UTC
(In reply to comment #10)
> If consolekit is installed at boot, starting hald will start consolekit via
> "use consolekit", so that hald doesn't have to spawn it's own consolekit
> process.

The problem is that it is not working, as I say in comment #8, when hald is started, it launches consolekit daemon but doesn't start init.d service :-/
Comment 12 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-09-12 19:11:34 UTC
(In reply to comment #11)
> The problem is that it is not working, as I say in comment #8, when hald is
> started, it launches consolekit daemon but doesn't start init.d service :-/
> 

It is most likely a problem with your setup. emerge --info please :)
Comment 13 Pacho Ramos gentoo-dev 2009-09-12 19:23:44 UTC
:-)

Portage 2.1.6.13 (default/linux/amd64/2008.0/desktop, gcc-4.3.2, glibc-2.9_p20081201-r2, 2.6.30-tuxonice-r5 x86_64)
=================================================================
System uname: Linux-2.6.30-tuxonice-r5-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T9300_@_2.50GHz-with-gentoo-1.12.11.1
Timestamp of tree: Sat, 12 Sep 2009 17:30:20 +0000
ccache version 2.4 [enabled]
app-shells/bash:     4.0_p28
dev-java/java-config: 2.1.8-r1
dev-lang/python:     2.6.2-r1
dev-util/ccache:     2.4-r7
dev-util/cmake:      2.6.4
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.6-r2
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.27-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/distfiles"
FEATURES="autoaddcvs ccache cvs distlocks fixpackages multilib-strict parallel-fetch protect-owned sandbox sfperms strict test test-fail-continue unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp.free.fr/mirrors/ftp.gentoo.org"
LANG="es_ES.UTF-8"
LC_ALL="es_ES.UTF-8"
LDFLAGS="-Wl,-O1"
LINGUAS="es es_ES en_US"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise /usr/portage/local/layman/wschlich-testing /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 applet avahi bash-completion berkdb bluetooth branding bzip2 cairo cdda cddb cdinstall cdr cleartype cli consolekit cracklib crypt css cups daap dbus dell djvu dri dts dvd dvdr dvi eds emboss encode evo exif fam fat ffmpeg firefox flac fortran fuse gdbm gif git glitz gnome gnome-keyring gpm gstreamer gtk hal iconv ieee1394 imagemagick isdnlog java jpeg kdeenablefinal kdehiddenvisibility kpathsea laptop latex libnotify lm_sensors lyx lzma mad mikmod mmx mmxext mono mp3 mp4 mpeg mudflap multilib musicbrainz nautilus ncurses network network-cron networkmanager nls nptl nptlonly ntfs nvidia ogg opengl openmp pam pango pch pcre pdf perl png ppds pppd python qt3support qt4 quicktime readline reflection reiserfs scanner sdl session spell spl sse sse2 ssl ssse3 startup-notification subversion svg sysfs t1lib tcpd threads thunar tiff truetype unicode usb v4l2 vcd vdpau vorbis webkit x264 xattr xcb xml xmp xorg xpm xulrunner xv xvid zeroconf zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="es es_ES en_US" USERLAND="GNU" VIDEO_CARDS="nvidia nv"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 14 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-09-12 19:25:31 UTC
(In reply to comment #13)
> sys-apps/baselayout: 1.12.11.1

It's _possible_ it's a baselayout-related bug. Could you try 1.12.12 ?
Comment 15 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-09-12 19:54:12 UTC
I've fixed the obviously wrong pidfile, but --oknodo is deprecated in baselayout 2.0 (doesn't even work). `use consolekit` should mean consolekit *will* be started before hald.

If it isn't, a different baselayout-related bug (or similar, depending on the root cause) should be opened. Closing FIXED, thanks for the patches.
Comment 16 Pacho Ramos gentoo-dev 2009-09-13 09:05:56 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > sys-apps/baselayout: 1.12.11.1
> 
> It's _possible_ it's a baselayout-related bug. Could you try 1.12.12 ?
> 

Solved after 1.12.12 update, thanks =)