Bug 279054 – sys-apps/util-linux-2.16 + sys-fs/e2fsprogs-1.41.8 no longer automatically detects ext2

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description sl 2009-07-25 14:40:03 UTC]

New libblkid inside util-linux, won't detect ext2 anymore. When kernel don't support ext2, but support ext4. This is a feature suppose the work by the source comments, but it's not.


Reproducible: Always

[Comment 1 Rafał Mużyło 2009-07-25 16:29:40 UTC]

Please elaborate on how exactly it fails to detect ext2 partitions.
It's a bit hard to reproduce a bug, if the report doesn't say what exactly the bug is.

[Comment 2 sl 2009-07-25 16:46:38 UTC]

It's easy to reproduce, just upgrade to newest version(e2fsprogs-libs-1.41.8+util-linux-2.16), de-selecct ext2 filesystem support from kernel, then blkid, and findfs won't find any ext2 partitions, and mount by label failed.

[Comment 3 James Earl Spahlinger 2009-07-29 04:57:59 UTC]

Does the older version of util-linux work. Try =sys-apps/util-linux-2.15.1 or =sys-apps/util-linux-2.14.2.

[Comment 4 sl 2009-07-31 08:45:56 UTC]

=sys-apps/util-linux-2.15.1 has not problem, because it build with external blkid (from e2fsprogs-libs).

Exchange following code block solve my problem:
--- shlibs/blkid/src/probers/ext.c.orig  2009-07-31 16:40:28.837616263 +0800
+++ shlibs/blkid/src/probers/ext.c       2009-07-31 16:40:40.356804616 +0800
@@ -483,11 +483,6 @@
        if (fi & EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)
                return -BLKID_ERR_PARAM;
 
-       /* Ext4 has at least one feature which ext3 doesn't understand */
-       if (!(frc & EXT3_FEATURE_RO_COMPAT_UNSUPPORTED) &&
-           !(fi  & EXT3_FEATURE_INCOMPAT_UNSUPPORTED))
-               return -BLKID_ERR_PARAM;
-
        /*
         * If the filesystem does not have a journal and ext2 is not
         * present, then force this to be detected as an ext2
@@ -498,6 +493,11 @@
            get_linux_version() >= EXT4_SUPPORTS_EXT2)
                goto force_ext4;
 
+       /* Ext4 has at least one feature which ext3 doesn't understand */
+       if (!(frc & EXT3_FEATURE_RO_COMPAT_UNSUPPORTED) &&
+           !(fi  & EXT3_FEATURE_INCOMPAT_UNSUPPORTED))
+               return -BLKID_ERR_PARAM;
+
        /*
         * If the filesystem is a OK for use by in-development
         * filesystem code, and ext4dev is supported or ext4 is not

[Comment 5 James Earl Spahlinger 2009-07-31 12:35:06 UTC]

Created attachment 199737 [details, diff]
patch submitted by reporter that fixes his issue

Thanks for the patch, I went ahead and attached it for you.

[Comment 6 Wormo (RETIRED) 2009-08-01 05:40:16 UTC]

Thanks for the patch, assigning to util-linux maintainers

[Comment 7 SpanKY 2009-08-16 18:32:56 UTC]

added patch from upstream to 2.16-r1, thanks