Bug 278368 – dev-java/swt-3.5 ebuild has wrong slot dep syntax (add repoman check?)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Harris Landgarten 2009-07-20 03:01:16 UTC]

the swt-3.5 ebuild prevents paludis from installing any package. paludis -ip world errors out with:

Unhandled exception:
  * In program paludis -ip world:
  * When performing install action from command line:
  * When executing install task:
  * When building dependency list:
  * When adding NamedSetDepSpec 'world':
  * When adding PackageDepSpec 'dev-java/swt':
  * When adding installed package 'dev-java/swt-3.5:3.5::installed':
  * When parsing metadata key 'DEPEND' from 'dev-java/swt-3.5:3.5::installed':
  * When parsing '>=virtual/jdk-1.4 !=dev-java/swt-3.5:*3 app-arch/unzip x11-libs/libX11 x11-libs/libXrender x11-libs/libXt x11-proto/xextproto x11-proto/inputproto dev-util/pkgconfig >=dev-libs/glib-2.6 >=x11-libs/gtk+-2.6.8 >=dev-libs/atk-1.10.2 cairo? ( >=x11-libs/cairo-1.4.14 ) gnome? ( =gnome-base/libgnome-2* =gnome-base/gnome-vfs-2* =gnome-base/libgnomeui-2* ) xulrunner? ( net-libs/xulrunner:1.9 ) opengl? ( virtual/opengl virtual/glu ) >=dev-java/java-config-2.1.6 >=dev-java/ant-core-1.7.0 >=dev-java/javatoolkit-0.3.0-r2':
  * When parsing from offset '18':
  * When parsing elike package dep spec '=dev-java/swt-3.5:*3':
  * When parsing generic package dep spec '=dev-java/swt-3.5:*3':
  * When validating slot name '*3':
  * Name '*3' is not a valid slot name (paludis::SlotNameError)


Reproducible: Always

[Comment 1 Vlastimil Babka (Caster) (RETIRED) 2009-07-20 13:01:57 UTC]

Ebuild fixed, thanks.

The offending dep was

!=dev-java/swt-3.5:*3

in DEPEND. Could a repoman check be added? Thanks.

[Comment 2 Zac Medico 2009-07-20 17:26:57 UTC]

Seems like it should have shown up as an unsatisfied dependency in repoman. Anyway, we can borrow whatever validation mechanism palidis/pms use.

[Comment 3 Vlastimil Babka (Caster) (RETIRED) 2009-07-20 17:49:02 UTC]

(In reply to comment #2)
> Seems like it should have shown up as an unsatisfied dependency in repoman.

It's a blocker, not satisfied means OK :) Does portage just expand the asterisk or treat it literally? 

> Anyway, we can borrow whatever validation mechanism palidis/pms use.

CCing them for input.

[Comment 4 Ciaran McCreesh 2009-07-20 17:54:30 UTC]

Clarify your question please. Are you wondering how Paludis parses package dep specs?

[Comment 5 Zac Medico 2009-07-20 19:18:18 UTC]

We just need a regular expression to validate the slot part.

[Comment 6 Ciaran McCreesh 2009-07-20 19:22:04 UTC]

Can get that from PMS:

A slot name may contain any of the characters [A-Za-z0-9+_.-]. It must not begin with a hyphen or a dot.

[Comment 7 Zac Medico 2009-09-24 20:19:03 UTC]

(In reply to comment #6)
> Can get that from PMS:
> 
> A slot name may contain any of the characters [A-Za-z0-9+_.-]. It must not
> begin with a hyphen or a dot.
> 

Thanks. We are using regular expressions for atom validation now, and it's fixed in portage-2.2_rc41.

[Comment 8 Zac Medico 2009-10-11 00:57:17 UTC]

This is fixed in 2.1.7.