Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 257980 - =app-text/xournal-0.4.2.1-r1 stable request (Annotating broken with latest updates)
Summary: =app-text/xournal-0.4.2.1-r1 stable request (Annotating broken with latest up...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robert Buchholz (RETIRED)
URL: http://bugs.archlinux.org/task/12923
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: gtk2.14-stable
  Show dependency tree
 
Reported: 2009-02-07 04:00 UTC by Gautam Iyer
Modified: 2009-08-02 13:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from upstream (0.4.2.1-pdf-annotation.patch,999 bytes, patch)
2009-02-07 04:01 UTC, Gautam Iyer
Details | Diff
Ebuild using the above patch (xournal-0.4.2.1-r1.ebuild,1.09 KB, text/plain)
2009-02-07 04:02 UTC, Gautam Iyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gautam Iyer 2009-02-07 04:00:47 UTC
From the ArchLinux bugreport:

Annotating in Xournal appears to be broken after the latest updates the 17th of January, when gtk2 was updates, by my estimation. It was working perfectly when I installed Arch Linux, not much over a week ago. There aren't any errors outputted when I open Xournal through the terminal except:

[code]
(xournal:30295): Gtk-WARNING **: GtkSpinButton: setting an adjustment with non-zero page size is deprecated

(xournal:30295): Gtk-WARNING **: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
[/code]

When I try to open a pdf, the page background does not change to reflect the pdf background image, and the Gtk WARNING error occurs again. However, when I try to save the file, the PDF file name does appear in the Save As menu, e.g. pdfname.pdf.xoj.

Steps to Reproduce:
1. Open a PDF in Xournal (open Xournal by the terminal if you wish to see the errors), by clicking Annotate PDF (in the File menu). Choose any PDF file; I've tried PDF files that were one-paged versus multiple pages, and there doesn't seem to be a difference.

2. Notice the background image. If you experience the bug (like I did), then the background image is the default lined paper. However, if you try File Save As, you'll see the behavior I reported in the summary.

Patch, and updated ebuild attached.
Comment 1 Gautam Iyer 2009-02-07 04:01:44 UTC
Created attachment 181215 [details, diff]
Patch from upstream
Comment 2 Gautam Iyer 2009-02-07 04:02:21 UTC
Created attachment 181216 [details]
Ebuild using the above patch
Comment 4 Robert Buchholz (RETIRED) gentoo-dev 2009-02-11 18:22:02 UTC
+*xournal-0.4.2.1-r1 (11 Feb 2009)
+
+  11 Feb 2009; Robert Buchholz <rbu@gentoo.org>
+  +files/xournal-0.4.2.1-pdf-annotation.patch, +xournal-0.4.2.1-r1.ebuild:
+  Bug fix: PDF annotation broken with latest GTK+ (bug #257980)
Comment 5 Arun Raghavan (RETIRED) gentoo-dev 2009-02-18 04:14:06 UTC
http://bugzilla.gnome.org/show_bug.cgi?id=569671 has a patch to fix this in GTK+. If there are no objections and nobody beats me to it, I'll try to get this in tonight.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-02-23 15:29:40 UTC
like gtk+ upstream dev said, patch looks acceptable, will be part of 2.14.7-r2
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-03-01 23:02:34 UTC
gtk+-2.14.7-r2 is in tree with this patch.
Comment 8 Gautam Iyer 2009-03-02 00:32:37 UTC
(In reply to comment #7)
> gtk+-2.14.7-r2 is in tree with this patch.
> 

In that case, could you make Xournal depend on >=gtk+-2.14.7-r2, and remove the attached patch?

Thanks,

GI
Comment 9 Robert Buchholz (RETIRED) gentoo-dev 2009-07-26 22:34:03 UTC
Sorry for letting this open for too long. I am still experiencing this bug using
=x11-libs/gtk-2.14.7-r2
=app-text/xournal-0.4.2.1

The workaround in the latest unstable xournal still works, and thus I'll request stabilization for now. Doing amd64 myself.

Gnome, do you want to handle this as a regression in GTK+ ? The upstream bug report also had a comment that the patch was incomplete.
Comment 10 Robert Buchholz (RETIRED) gentoo-dev 2009-07-26 22:35:58 UTC
Arches, please test and mark stable:
=app-text/xournal-0.4.2.1-r1
Comment 11 Markus Meier gentoo-dev 2009-08-02 13:15:31 UTC
x86 stable, all arches done.