Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 252995 - =sys-apps/portage-2.1.6.4 does not check for unread news items with --pretend
Summary: =sys-apps/portage-2.1.6.4 does not check for unread news items with --pretend
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 210077 254662
  Show dependency tree
 
Reported: 2008-12-29 14:49 UTC by Fab
Modified: 2009-01-12 20:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
show news after --pretend (news_pretend.patch,485 bytes, text/plain)
2008-12-30 07:44 UTC, Zac Medico
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fab 2008-12-29 14:49:11 UTC
Hi,

I'm currently testing the news feature using eselect-news and the sample news item from bug #251810. GLEP 42 say :

---
Checks for new news messages should be displayed:

    * After an emerge sync
    * After an emerge --pretend
    * Before an emerge <target> (which may also include a red warning message)
---


Portage does not check for new news items with --pretend :

# eselect news count
1

# eselect news list
Unread news items:
  2008-12-20-portage-2.1.6  Changes for Portage 2.1.6
Read news items:
  (none found)              

# emerge --pretend portage eselect-news

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   ] sys-apps/portage-2.1.6.4 
[ebuild   R   ] app-admin/eselect-news-20080320 


Thanks.

Reproducible: Always




# emerge --info
Portage 2.1.6.4 (default/linux/x86/2008.0/desktop, gcc-4.1.2, glibc-2.6.1-r0, 2.6.25-gentoo-r8 i686)
=================================================================
System uname: Linux-2.6.25-gentoo-r8-i686-Intel-R-_Pentium-R-_4_CPU_2.40GHz-with-glibc2.0
Timestamp of tree: Mon, 29 Dec 2008 11:45:01 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7-r1, 2.1.6-r1
dev-lang/python:     2.5.2-r7
dev-util/ccache:     2.4-r7
dev-util/cmake:      2.4.6-r1
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.3.0-r1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe -ggdb"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -march=pentium4 -pipe -ggdb"
DISTDIR="/data/distpack/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
FEATURES="buildpkg ccache distlocks fixpackages parallel-fetch protect-owned sandbox sfperms splitdebug strict unmerge-orphans userfetch userpriv usersandbox"
GENTOO_MIRRORS="ftp://mirror.ovh.net/gentoo-distfiles/ ftp://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/"
LANG="fr_FR.UTF-8"
LC_ALL="fr_FR.UTF-8"
LDFLAGS="-Wl,-O1"
LINGUAS="fr"
MAKEOPTS="-j2"
PKGDIR="/data/distpack/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/gentrees/portage"
PORTDIR_OVERLAY="/var/gentrees/layman/gnome /var/gentrees/overlay-perso"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X aac acl acpi alsa apache2 apm audiofile berkdb branding bzip2 cairo cdr cli cracklib crypt cups curl dbus dri dts dvd dvdr dvdread emboss encode evo exif fam ffmpeg flac fortran gdbm gif gnome gpm gstreamer gtk hal iconv imlib isdnlog java jpeg libnotify logrotate mad midi mikmod mmx mp3 mpeg mudflap nautilus ncurses nls nptl nptlonly nsplugin ogg openal opengl openmp oss pam pcre pdf perl png ppds pppd python qt3 qt3support qt4 quicktime readline reflection sdl session spell spl sse sse2 ssl startup-notification svg sysfs tcpd tiff truetype unicode usb vorbis win32codecs x86 xine xml xorg xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="fr" USERLAND="GNU" VIDEO_CARDS="nvidia nv"
Unset:  CPPFLAGS, CTARGET, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Zac Medico gentoo-dev 2008-12-30 07:44:35 UTC
Created attachment 176842 [details]
show news after --pretend

If this patch is saved as /tmp/news_pretend.patch, then it can be applied as follows:

 patch /usr/lib/portage/pym/_emerge/__init__.py /tmp/news_pretend.patch
Comment 2 Fab 2008-12-30 10:11:09 UTC
Patch applied, it works. Thanks.
Comment 3 Zac Medico gentoo-dev 2009-01-12 20:12:15 UTC
Thanks for testing. This is fixed in 2.1.6.5 and 2.2_rc21.