Bug 249236 – media-libs/spandsp headers makes build of media-radio/svxlink with gcc-4.3 fail

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Volkov (RETIRED) 2008-11-29 09:30:04 UTC]

media-radio/svxlink does not builds with gcc-4.3. Actually this is bug in media-libs/spandsp since fir.h uses memset(), bug does not #include <string.h>:

In file included from /usr/include/spandsp.h:50,
                 from SpanDtmfDecoder.cpp:42:
/usr/include/spandsp/fir.h: In function 'const int16_t* fir16_create(fir16_state_t*, const int16_t*, int)':
/usr/include/spandsp/fir.h:97: error: 'memset' was not declared in this scope
/usr/include/spandsp/fir.h: In function 'void fir16_flush(fir16_state_t*)':
/usr/include/spandsp/fir.h:108: error: 'memset' was not declared in this scope
/usr/include/spandsp/fir.h: In function 'const int16_t* fir32_create(fir32_state_t*, const int32_t*, int)':
/usr/include/spandsp/fir.h:217: error: 'memset' was not declared in this scope
/usr/include/spandsp/fir.h: In function 'void fir32_flush(fir32_state_t*)':
/usr/include/spandsp/fir.h:224: error: 'memset' was not declared in this scope
/usr/include/spandsp/fir.h: In function 'const float* fir_float_create(fir_float_state_t*, const float*, int)':
/usr/include/spandsp/fir.h:265: error: 'memset' was not declared in this scope
make[3]: *** [SpanDtmfDecoder.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2

[Comment 1 Yaroslav Gorbunov 2008-11-29 21:59:55 UTC]

Created attachment 173809 [details, diff]
proposed patch for spandsp-0.0.2

proposed patch for spandsp-0.0.2_pre25, spandsp-0.0.2_pre26, spandsp-0.0.3_pre26

spandsp-0.0.5_pre3 in not affected.
spandsp-0.0.5_pre4 have other issue.

[Comment 2 Yaroslav Gorbunov 2008-11-29 22:02:58 UTC]

Created attachment 173810 [details]
spandsp-0.0.2_pre25.ebuild.diff

[Comment 3 Yaroslav Gorbunov 2008-11-29 22:03:21 UTC]

Created attachment 173811 [details]
spandsp-0.0.2_pre26.ebuild.diff

[Comment 4 Yaroslav Gorbunov 2008-11-29 22:03:41 UTC]

Created attachment 173812 [details]
spandsp-0.0.3_pre26.ebuild.diff

[Comment 5 Peter Volkov (RETIRED) 2008-11-30 10:51:39 UTC]

(In reply to comment #1)
> spandsp-0.0.5_pre4 have other issue.

Yaroslav, what do you mean by that?

[Comment 6 Yaroslav Gorbunov 2008-11-30 11:58:36 UTC]

(In reply to comment #5)
> (In reply to comment #1)
> > spandsp-0.0.5_pre4 have other issue.
> 
> Yaroslav, what do you mean by that?
> 

I reported bug http://bugs.gentoo.org/show_bug.cgi?id=249338

[Comment 7 Peter Volkov (RETIRED) 2008-11-30 13:03:21 UTC]

voip, give me your Ok to fix this bug.

After I receive answer from upstream I'm going ether to commit fixed spandsp-0.0.2_pre26-r1 and done with this bug or I'm going to bump and unmask 0.0.3, which although requires similar patch is newer, and is not beta release. Also if we manage to fix some further problems with spandsp-0.0.6_beta2 I'm going to bump it too (but keep masked until all packages listed in our tinderbox [1] are not know to build against this new version. What do you think?

[1] http://tinderbox.dev.gentoo.org/misc/dindex/media-libs/spandsp

And thank you for your work Yaroslav. I hope we'll fix all known issues with this package very soon.

[Comment 8 Stefan Briesenick (RETIRED) 2008-12-09 15:41:37 UTC]

@peter: please do what is necessary

[Comment 9 Peter Volkov (RETIRED) 2008-12-15 12:31:58 UTC]

I've bumped version and unmasked spandsp and thus fixed this bug. I think maintaining old versions is waist of time, since upstream told us to fix applications and use >=spandsp-0.0.6_pre2.ebuild. Thank you Yaroslav. Your investigation stimulated me to fix this bug.