Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 249338 - media-radio/svxlink-080730 + media-libs/spandsp-0.0.5_pre4 - /usr/include/spandsp/dtmf.h:228: error: too few arguments to function ‘void dtmf_rx_parms(dtmf_rx_state_t*, int, int, int, int)’
Summary: media-radio/svxlink-080730 + media-libs/spandsp-0.0.5_pre4 - /usr/include/spa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-30 02:40 UTC by Yaroslav Gorbunov
Modified: 2008-12-15 12:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (svxlink-080730-spandsp-0.0.5_pre4.patch,774 bytes, patch)
2008-11-30 02:49 UTC, Yaroslav Gorbunov
Details | Diff
svxlink-080730.ebuild.diff (svxlink-080730.ebuild.diff,373 bytes, text/plain)
2008-11-30 02:51 UTC, Yaroslav Gorbunov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Gorbunov 2008-11-30 02:40:04 UTC
void dtmf_rx_parms(dtmf_rx_state_t*, int, int, int, int) interface was changed since media-libs/spandsp-0.0.5_pre3.
5th parameter int threshold (The minimum acceptable tone level for detection, in dBm0. <= -99 to leave unchanged.) was added. 

--- Compiling SpanDtmfDecoder.cpp...
/usr/include/spandsp/dtmf.h: In member function ‘virtual bool SpanDtmfDecoder::initialize()’:
/usr/include/spandsp/dtmf.h:228: error: too few arguments to function ‘void dtmf_rx_parms(dtmf_rx_state_t*, int, int, int, int)’
SpanDtmfDecoder.cpp:169: error: at this point in file
make[3]: *** [SpanDtmfDecoder.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all] Error 2
make: *** [all] Error 2
 *
 * ERROR: media-radio/svxlink-080730 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2907:  Called die
 * The specific snippet of code:
 *       emake -j1 || die "emake failed"
 *  The die message:
 *   emake failed
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/media-radio/svxlink-080730/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-radio/svxlink-080730/temp/environment'.
 * This ebuild is from an overlay: '/usr/local/portage/'
 *

Reproducible: Always

Steps to Reproduce:
1. ACCEPT_KEYWORDS="~x86" emerge -v =spandsp-0.0.5_pre4  =svxlink-080730
2.
3.




emerge --info
Portage 2.1.6_rc2 (default-linux/x86/2007.0, gcc-4.3.2, glibc-2.7-r2, 2.6.25-gentoo-r9 i686)
=================================================================
System uname: Linux-2.6.25-gentoo-r9-i686-Intel-R-_Core-TM-2_CPU_T5500_@_1.66GHz-with-glibc2.0
Timestamp of tree: Fri, 28 Nov 2008 10:30:15 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.6
dev-lang/python:     2.4.4-r14, 2.5.2-r7
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r2
sys-devel/automake:  1.7.9-r1, 1.9.6-r2, 1.10.1-r1
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=core2 -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -march=core2 -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache collision-protect distlocks parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://mirror.yandex.ru/gentoo-distfiles/"
LANG="ru_RU.UTF-8"
LC_ALL=""
LDFLAGS=""
LINGUAS="en ru"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/berkano /usr/local/portage/layman/desktop-effects /usr/local/portage/layman/sunrise /usr/local/portage/layman/yarik-overlay /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X acl acpi alsa berkdb cli cracklib crypt css dri fortran fuse gdbm gpm hal iconv isdnlog kde lm_sensors midi mmx mudflap ncurses nls nptl nptlonly nvidia opengl openmp pam pcre perl pppd python qt3 readline reflection samba session spl sse sse2 sse3 ssl ssse3 tcpd unicode userlocales utf8 x86 xorg xvmc zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="canon ptp2" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en ru" USERLAND="GNU" VIDEO_CARDS="nvidia vesa i810"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Yaroslav Gorbunov 2008-11-30 02:49:35 UTC
Created attachment 173842 [details, diff]
proposed patch

dtmf_rx_parms(&p->rx_state, FALSE, max_fwd_twist, max_rev_twist, -100); /*5th param threshold The minimum acceptable tone level for detection, in dBm0. <= -99 to leave unchanged. */
Comment 2 Yaroslav Gorbunov 2008-11-30 02:51:57 UTC
Created attachment 173844 [details]
svxlink-080730.ebuild.diff
Comment 3 Wormo (RETIRED) gentoo-dev 2008-11-30 08:15:00 UTC
Thanks for submitting your fix! Since I see there is currently no maintainer for this ebuild, I will take this bug myself. I have some friends who are hams :)
Comment 4 Peter Volkov (RETIRED) gentoo-dev 2008-11-30 12:44:49 UTC
(In reply to comment #3)
> Thanks for submitting your fix! Since I see there is currently no maintainer
> for this ebuild, I will take this bug myself. I have some friends who are hams
> :)

Wormo wait a bit. I'm currently working on adding newer version of this library in the tree. It has some problems but I've get in touch with upstream and I hope we'll manage to fix them all :)
Comment 5 Peter Volkov (RETIRED) gentoo-dev 2008-11-30 13:11:01 UTC
Just to make a bit clearer myself. I'm working on adding 
media-libs/spandsp library into the tree and I'm testing it with svxlink package. I've already managed to fix --as-needed problem for this package so I'm going to commit both fixes for it in one go. Now I'm awaiting answer from quite helpful spandsp: I want to know what library version Steve considers most stable and then depending on this I'll do all commits.

And speaking about this patch. I think it's better to use SPANDSP_RELEASE_DATE to check for library version in svxlink sources and in ebuild apply patch unconditionally. Such fix will be more likely to be accepted by svxlink upstream.
Comment 6 Wormo (RETIRED) gentoo-dev 2008-12-07 07:37:41 UTC
Peter, sounds like this bug will be in good hands, turning it over to you :)
Comment 7 Peter Volkov (RETIRED) gentoo-dev 2008-12-15 12:28:05 UTC
Patch was added to the tree, thank you Yaroslav. I forced to use newer spandsp library as it is considered to be most stable and useful by upstream. So fixed.