245585 – media-video/qc-usb-messenger-1.8: Patch for compilation on PowerPC

Bug 245585 - media-video/qc-usb-messenger-1.8: Patch for compilation on PowerPC

Summary: media-video/qc-usb-messenger-1.8: Patch for compilation on PowerPC

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	PPC Linux

Importance:	High normal (vote)
Assignee:	Santiago M. Mola (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-11-04 20:28 UTC by Thomas Juerges
Modified:	2009-01-09 21:28 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Makefile patch for PowerPC architectures. (qc-usb-messenger-1.8-Makefile.patch,597 bytes, patch) 2008-11-04 20:28 UTC, Thomas Juerges	Details \| Diff
Added ~ppc to supported architectures. Uses patch from bug 245581! (qc-usb-messenger-1.8-r1.ebuild,1.26 KB, text/plain) 2008-11-04 20:29 UTC, Thomas Juerges	Details
Patch for kernels >= 2.6.28. (qc-usb-messenger-1.8-qc-driver-2.6.28.patch,3.81 KB, patch) 2008-12-28 19:25 UTC, Thomas Juerges	Details \| Diff
Ebuild for kernels >= 2.6.28. (qc-usb-messenger-1.8-r2.ebuild,1.31 KB, text/plain) 2008-12-28 19:27 UTC, Thomas Juerges	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas Juerges 2008-11-04 20:28:12 UTC

Attached is a patch for the Makefile for compilation on PowerPC architectures.  Not tested on PPC64 but on PPC32.  The camera works there on a 2.6.27.4 kernel with the patch from [https://bugs.gentoo.org/show_bug.cgi?id=245581].

Comment 1 Thomas Juerges 2008-11-04 20:28:39 UTC

Created attachment 170734 [details, diff]
Makefile patch for PowerPC architectures.

Comment 2 Thomas Juerges 2008-11-04 20:29:36 UTC

Created attachment 170736 [details]
Added ~ppc to supported architectures.  Uses patch from bug 245581!

Comment 3 Santiago M. Mola (RETIRED) gentoo-dev

2008-11-05 17:22:44 UTC

Let's see if someone from ppc team can test this and want to keyword qc-usb-messenger once the patch is added.

Thomas, thanks for the patches! In the mean time, it would be great if you send upstream this patch as well as the one in bug 245581.

Comment 4 Thomas Juerges 2008-11-09 03:59:07 UTC

(In reply to comment #3)
> Thomas, thanks for the patches! In the mean time, it would be great if you send
> upstream this patch as well as the one in bug 245581.
> 

For the record: I just sent the maintainer Joseph Jezak an email about the patches.

Comment 5 Thomas Juerges 2008-12-28 19:25:57 UTC

Created attachment 176645 [details, diff]
Patch for kernels >= 2.6.28.

This patch is necessary to make the driver work on kernels >= 2.6.28.

Comment 6 Thomas Juerges 2008-12-28 19:27:54 UTC

Created attachment 176647 [details]
Ebuild for kernels >= 2.6.28.

This ebuild requires the patch qc-usb-messenger-1.8-qc-driver-2.6.28.patch.

Comment 7 Thomas Juerges 2008-12-28 19:44:58 UTC

Just for the record:  vanilla kernel 2.6.28 breaks compilation of media-video/qc-usb-messenger due to a change in the V4L2 API.  Bug [http://bugs.gentoo.org/show_bug.cgi?id=252467] should be updated accordingly.

Comment 8 Santiago M. Mola (RETIRED) gentoo-dev

2008-12-28 20:36:49 UTC

Please, use one report for each bug.

We'll handle the 2.6.28 problem in bug #252849. Could you upload your patch there? Thanks.

Comment 9 Thomas Juerges 2008-12-28 21:58:23 UTC

(In reply to comment #8)
> Please, use one report for each bug.

Okay.
 
> We'll handle the 2.6.28 problem in bug #252849. Could you upload your patch
> there? Thanks.
> 

Done.  Added a comment there which points out that the -r2 ebuild from here shall be used with this patch,

Comment 10 Santiago M. Mola (RETIRED) gentoo-dev

2009-01-09 21:28:44 UTC

Thanks Thomas, your patch is included with 1.8-r2 and ~ppc keyword is added.