Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 243206 - patch to allow media-gfx/gthumb-2.10.10 to compile on solaris
Summary: patch to allow media-gfx/gthumb-2.10.10 to compile on solaris
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Solaris
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 12:07 UTC by Daniel Vergien
Modified: 2010-04-26 15:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild that works on x86-solaris (gthumb-2.10.10.ebuild,1.49 KB, text/plain)
2008-10-22 12:07 UTC, Daniel Vergien
Details
patch needed for solaris (gthumb-2.10.10-solaris.patch,861 bytes, patch)
2008-10-22 12:08 UTC, Daniel Vergien
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Vergien 2008-10-22 12:07:14 UTC
I've done the following things to the ebuild to get it run on x86-solaris:
- add the ~x86-solaris keyword
- add a patch for solaris, since the solaris libc is not having mkdtemp. The patch is from pkgsrc - see URL. The patch seems to also needed on some other *unixes: http://www.gnu.org/software/gnulib/manual/html_node/mkdtemp.html

- One problem is still that if I use the raw USE-flag, libopenraw see Bug 243200 is not found.
Comment 1 Daniel Vergien 2008-10-22 12:07:54 UTC
Created attachment 169404 [details]
ebuild that works on x86-solaris
Comment 2 Daniel Vergien 2008-10-22 12:08:10 UTC
Created attachment 169406 [details, diff]
patch needed for solaris
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-27 14:14:25 UTC
upstream report: http://bugzilla.gnome.org/show_bug.cgi?id=558104
Comment 4 Daniel Vergien 2008-10-27 14:19:39 UTC
> - One problem is still that if I use the raw USE-flag, libopenraw see Bug
> 243200 is not found.

The Problem which libopenraw seems to be that there is no gnome-config

checking for LIBOPENRAW... sh: gnome-config: not found
no


Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-27 14:43:36 UTC
(In reply to comment #2)
> Created an attachment (id=169406) [edit]
> patch needed for solaris
> 

gnome team:

Hi,
We have this patch applied to the prefix tree and I submitted it upstream in comment #3. We (the prefix team) would be much obliged if you would accept the patch in the gentoo-x86 tree. You can see everything relevant here: http://overlays.gentoo.org/proj/alt/changeset/33202

Thanks for your time.

Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-11-27 23:11:31 UTC
replacing current URL by upstream bug report:
http://mail-index.netbsd.org/pkgsrc-bugs/2008/01/09/msg000201.html

ftr, I won't accept a patch that introduces a security issue even if it's for one specific platform. I think applying patches based on CHOST is probably the worse thing we could do to bypass portage functions and it would be detrimental to testing of the patch & ebuild. I hope upstream can come up with a better solution.
Comment 7 Romain Perier (RETIRED) gentoo-dev 2009-10-25 11:27:52 UTC
I totally agree with Gilles, that's nice to make a fix which builds, but you introduce a security issue...
Comment 8 Fabian Groffen gentoo-dev 2009-10-25 17:10:55 UTC
this should have been at least ifdeffed
Comment 9 Romain Perier (RETIRED) gentoo-dev 2009-10-25 19:30:50 UTC
(In reply to comment #8)
> this should have been at least ifdeffed
> 

+1

why this patch does not include conditionnal code (using macro-constant) ?
usually platforms introduce macro (like FREEBSD does, or LINUX) not solaris ?
Comment 10 Fabian Groffen gentoo-dev 2009-10-25 19:34:21 UTC
No, configure should check for mkdtemp, mkstemp, and mktemp.  Hardcoding OS specifics is stupid.  Once a new release of Solaris gets mkdtemp suddenly your code doesn't work any more there.
Comment 11 Pacho Ramos gentoo-dev 2010-03-13 20:18:44 UTC
What is the status of this with gthumb-2.11?
Comment 12 Daniel Vergien 2010-03-14 13:07:22 UTC
Fails with something else:

/nilfisk/home/dve/gentoo-kde/bin/bash ../libtool --tag=CC   --mode=link i386-pc-solaris2.10-gcc  -march=core2 -mtune=core2 -O2 -pipe   -o gthumb GNOME_GThumb-stubs.o GNOME_GThumb-skels.o GNOME_GThumb-common.o bookmark-list.o catalog-list.o dlg-bookmarks.o dlg-brightness-contrast.o dlg-catalog.o dlg-categories.o dlg-change-date.o dlg-color-balance.o dlg-comment.o dlg-convert.o dlg-crop.o dlg-file-utils.o dlg-hue-saturation.o dlg-image-prop.o dlg-open-with.o dlg-posterize.o dlg-preferences.o dlg-redeye-removal.o dlg-rename-series.o dlg-reset-exif.o dlg-scale-image.o dlg-scale-series.o dlg-write-to-cd.o gs-fade.o gth-application.o gth-batch-op.o gth-browser.o gth-browser-actions-callbacks.o gth-category-selection-dialog.o gth-dir-list.o gth-exif-data-viewer.o gth-filter-bar.o gth-folder-selection-dialog.o gth-fullscreen.o gth-fullscreen-actions-callbacks.o gth-image-history.o gth-image-selector.o gth-location.o gth-monitor.o gth-viewer.o gth-viewer-actions-callbacks.o gth-window.o gth-window-actions-callbacks.o gth-window-utils.o gthumb-preloader.o gtkcellrendererthreestates.o main.o totem-scrsaver.o rotation-utils.o ../libgthumb/jpegutils/libgthumb-jpegutils.la ../libgthumb/libgthumb.la   -pthread -Wl,--export-dynamic -L/nilfisk/home/dve/gentoo-kde/usr/lib -lgnomeui-2 -lSM -lICE -lbonoboui-2 -lgnomecanvas-2 -lgnome-2 -lpopt -lart_lgpl_2 -lbonobo-2 -lbonobo-activation -lORBit-2 -lgnomevfs-2 -lgconf-2 -lgthread-2.0 -lrt -lexif -lm -lglade-2.0 -lgtk-x11-2.0 -lxml2 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl   -ljpeg -lm -lz  -lXrender -lXext   -lX11 -lXext -lXxf86vm -lX11 -lXtst
i386-pc-solaris2.10-gcc -march=core2 -mtune=core2 -O2 -pipe -o .libs/gthumb GNOME_GThumb-stubs.o GNOME_GThumb-skels.o GNOME_GThumb-common.o bookmark-list.o catalog-list.o dlg-bookmarks.o dlg-brightness-contrast.o dlg-catalog.o dlg-categories.o dlg-change-date.o dlg-color-balance.o dlg-comment.o dlg-convert.o dlg-crop.o dlg-file-utils.o dlg-hue-saturation.o dlg-image-prop.o dlg-open-with.o dlg-posterize.o dlg-preferences.o dlg-redeye-removal.o dlg-rename-series.o dlg-reset-exif.o dlg-scale-image.o dlg-scale-series.o dlg-write-to-cd.o gs-fade.o gth-application.o gth-batch-op.o gth-browser.o gth-browser-actions-callbacks.o gth-category-selection-dialog.o gth-dir-list.o gth-exif-data-viewer.o gth-filter-bar.o gth-folder-selection-dialog.o gth-fullscreen.o gth-fullscreen-actions-callbacks.o gth-image-history.o gth-image-selector.o gth-location.o gth-monitor.o gth-viewer.o gth-viewer-actions-callbacks.o gth-window.o gth-window-actions-callbacks.o gth-window-utils.o gthumb-preloader.o gtkcellrendererthreestates.o main.o totem-scrsaver.o rotation-utils.o -pthread -Wl,--export-dynamic  ../libgthumb/jpegutils/.libs/libgthumb-jpegutils.a ../libgthumb/.libs/libgthumb.so -L/nilfisk/home/dve/gentoo-kde/usr/lib /nilfisk/home/dve/gentoo-kde/usr/lib/libgnomeui-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgnome-keyring.so /nilfisk/home/dve/gentoo-kde/usr/lib/libbonoboui-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libSM.so /nilfisk/home/dve/gentoo-kde/usr/lib/libICE.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgnomecanvas-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgailutil.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXinerama.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXrandr.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXcursor.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXcomposite.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXdamage.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXfixes.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgnome-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libpopt.so /nilfisk/home/dve/gentoo-kde/usr/lib/libart_lgpl_2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libbonobo-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libbonobo-activation.so /nilfisk/home/dve/gentoo-kde/usr/lib/libORBitCosNaming-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgnomevfs-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgnutls.so /nilfisk/home/dve/gentoo-kde/usr/lib/libtasn1.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgcrypt.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgpg-error.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgconf-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libORBit-2.so /nilfisk/home/dve/gentoo-kde/usr/lib/libdbus-glib-1.so /nilfisk/home/dve/gentoo-kde/usr/lib/libdbus-1.so -lbsm /nilfisk/home/dve/gentoo-kde/usr/lib/libgthread-2.0.so -lrt /nilfisk/home/dve/gentoo-kde/usr/lib/libexif.so /nilfisk/home/dve/gentoo-kde/usr/lib/libglade-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgtk-x11-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libxml2.so -lpthread -lnsl /nilfisk/home/dve/gentoo-kde/usr/lib/libgdk-x11-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libatk-1.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgdk_pixbuf-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgio-2.0.so -lresolv -lmlib /nilfisk/home/dve/gentoo-kde/usr/lib/libpangocairo-1.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libpangoft2-1.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libcairo.so /nilfisk/home/dve/gentoo-kde/usr/lib/libpixman-1.so /nilfisk/home/dve/gentoo-kde/usr/lib/libpng12.so /nilfisk/home/dve/gentoo-kde/usr/lib/libpango-1.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libfontconfig.so /nilfisk/home/dve/gentoo-kde/usr/lib/libfreetype.so /nilfisk/home/dve/gentoo-kde/usr/lib/libexpat.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgobject-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libgmodule-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libglib-2.0.so /nilfisk/home/dve/gentoo-kde/usr/lib/libintl.so /nilfisk/home/dve/gentoo-kde/usr/lib/libiconv.so -lc /nilfisk/home/dve/gentoo-kde/usr/lib/libjpeg.so -lm -lz /nilfisk/home/dve/gentoo-kde/usr/lib/libXrender.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXxf86vm.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXtst.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXi.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXext.so /nilfisk/home/dve/gentoo-kde/usr/lib/libX11.so /nilfisk/home/dve/gentoo-kde/usr/lib/libxcb.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXau.so /nilfisk/home/dve/gentoo-kde/usr/lib/libXdmcp.so -lsocket  -Wl,--rpath -Wl,/nilfisk/home/dve/gentoo-kde/usr/lib
/nilfisk/home/dve/gentoo-kde/usr/lib/gcc/i386-pc-solaris2.10/4.4.3/../../../../i386-pc-solaris2.10/bin/ld: ../libgthumb/.libs/libgthumb.so: _etext: invalid version 32225 (max 0)
../libgthumb/.libs/libgthumb.so: could not read symbols: Bad value
collect2: ld returned 1 exit status
Comment 13 Pacho Ramos gentoo-dev 2010-03-14 13:19:01 UTC
If a patch is available to compile gthumb-2.11 on solaris, it should be send to upstream, if not, gthumb should probably  simply have no keyword for solaris
Comment 14 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-04-26 15:42:26 UTC
(In reply to comment #13)
> If a patch is available to compile gthumb-2.11 on solaris, it should be send to
> upstream, if not, gthumb should probably  simply have no keyword for solaris
> 

Closing this bug as the original intention was lost (or is obsolete now). A new bug should be opened for new issues.

%% pwd
/home/jolexa/portage/linux-64/var/tmp/portage/media-gfx/gthumb-2.11.2.1/work/gthumb-2.11.2.1
%% find . |xargs grep mkdtemp
%%