Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 243200 - media-libs/libopenraw-0.0.5 patch to #include <strings.h>
Summary: media-libs/libopenraw-0.0.5 patch to #include <strings.h>
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Solaris
: High normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 11:56 UTC by Daniel Vergien
Modified: 2008-10-29 08:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (libopenraw-0.0.5.ebuild,961 bytes, text/plain)
2008-10-22 11:57 UTC, Daniel Vergien
Details
adds #include<strings.h> to ljpegdecompressor.cpp (libopenraw-0.0.5-ljpegdcompressor.patch,459 bytes, patch)
2008-10-22 11:57 UTC, Daniel Vergien
Details | Diff
updated patch to use cstring instead of strings.h (libopenraw-0.0.5-ljpegdcompressor.patch,457 bytes, text/plain)
2008-10-27 14:20 UTC, Jeremy Olexa (darkside) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Vergien 2008-10-22 11:56:40 UTC
Added --with-boost=${EPREFIX}/usr to the econf call. Else boost is not found.
At least on Solaris #include<strings.> in lib/ljpegdecompressor.cpp is needed to find bcopy.
Comment 1 Daniel Vergien 2008-10-22 11:57:17 UTC
Created attachment 169400 [details]
ebuild
Comment 2 Daniel Vergien 2008-10-22 11:57:59 UTC
Created attachment 169402 [details, diff]
adds #include<strings.h> to ljpegdecompressor.cpp
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-22 14:31:36 UTC
added to the tree, thanks!
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-22 14:36:52 UTC
(In reply to comment #2)
> Created an attachment (id=169402) [edit]
> adds #include<strings.h> to ljpegdecompressor.cpp
> 

Hi freedesktop team,
Would you consider this patch for the gentoo-x86 tree? I have tested it on amd64-linux and it does not cause any problems (and it is needed for x86-solaris). One of the Gentoo Prefix goals is to have as little as possible changes compared to the gentoo-x86 tree. Thanks for your time. (Of course, if you are *strongly* against this patch, that is fine as well. But it is a pretty trivial patch)

Comment 5 Rémi Cardona (RETIRED) gentoo-dev 2008-10-23 09:20:36 UTC
Hum, you should probably use <cstring> instead of <strings.h>

Could you also report the bug upstream and send them your patch?

Thanks
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-23 12:56:22 UTC
(In reply to comment #5)
> Hum, you should probably use <cstring> instead of <strings.h>

Yea, that was already pointed out, slipped my mind.. ;)

> Could you also report the bug upstream and send them your patch?

bugs.fd.o seems down and I won't be able to work on Gentoo stuff until next week (busy weekend), I won't be offended if someone else gets to it =D
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-27 14:20:47 UTC
Created attachment 170006 [details]
updated patch to use cstring instead of strings.h
Comment 8 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-27 14:23:22 UTC
Upstream report: https://bugs.freedesktop.org/show_bug.cgi?id=18243
Comment 9 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-10-27 16:25:10 UTC
(In reply to comment #8)
> Upstream report: https://bugs.freedesktop.org/show_bug.cgi?id=18243
> 

Upstream has applied this to the git master branch. Could it be applied to gentoo-x86 now? TIA.
Comment 10 Rémi Cardona (RETIRED) gentoo-dev 2008-10-29 08:54:38 UTC
Committed without a revbump.

@Daniel, epatch goes into src_unpack, not src_compile. Just letting you know :)

Thanks to the both of you.