I don't know the build system for this program (and this is a generic bug template so I cannot tell you which program exactly is), but my tests shows that it's not respecting CFLAGS (or CXXFLAGS) properly. Please look into it, since it's important to respect user CFLAGS and CXXFLAGS. Warning: this bug might look like a false positive because you actually have your CFLAGS being used; this happens if the CFLAGS are "set in stone" in the build system during src_unpack/src_prepare. While QA has not as of this moment expressed to me a preference, I'd sincerely suggest to avoid the set-in-stone approach, so that ebuild commands could work to reproduce the actual results. To avoid the set in stone approach: - consider just changing CFLAGS= to CFLAGS+= if the build system enables warnings; - if the buildsystem does not use CFLAGS variable at all, in the sed use '$(CFLAGS)', single quoted, so that the CFLAGS variable is picked up; - use '$(OPTCFLAGS)' in the sed and then use make OPTCFLAGS=$CFLAGS. Thanks, Diego
Created attachment 191581 [details, diff] Respect user set CC, CFLAGS and LDFLAGS, and various other QA fixes This also fixes bug #241016
Created attachment 191963 [details, diff] Respect user set CC, CFLAGS and LDFLAGS, and various other QA fixes. This also fixes bug #241016
Does that emake line really fix the stripping issue?
Yes, see below. espen@suspended ~/Development/gentoo/redir-2.2.1 $ grep LDFLAGS Makefile LDFLAGS = -s ${CC} ${LDFLAGS} -o redir ${OBJS} ${LIBS} I have also tested the ebuild with the patch applied. :)
30 May 2009; Jeremy Olexa <darkside@gentoo.org> redir-2.2.1.ebuild: (non maintainer commit) Respect flags and QA fixes, bug 241080 by Espen Hustad