Claws fails to build with gtk 2.14. Patch attached.
Created attachment 166600 [details, diff] Patch to fix gtk includes
GTK_DISABLE_SINGLE_INCLUDES isn't actually defined, so this I claim this ought to work fine really, but because deprecated things are used (GtkCList, etc) this isn't really checked I suppose and fails, so as gtk3 will unfortunately not support single includes, this patch is appropriate enough and we don't really need to care about single include header circular deps as I think this seems to be the case here. So just marking blocker .... which remi already did while I was writing this
... and I apparently deleted with the mid-air collision, restoring
and keep maintainers in the loop :)
This gets fixed by http://bugzilla.gnome.org/show_bug.cgi?id=536767 as well - which is a patch against gtk+ itself. I'm probably going to include this, so the patch here isn't strictly necessary then until gtk3 (at which point a lot more is needed anyhow, like not using GtkCList/GtkCTree in the first place). However if upstream refuses to include this in the future for some reason, I might like to back it out, but I see no reason why upstream will eventually refuse to include this simple fix (or just need to be convincing enough).
The header patch is now part of gtk+-2.14.3 (without revbump, but I'm revbumping it with a bunch of other stuff before unmasking anyway), so claws-mail builds fine for me against gtk+-2.14 now
Can we close this bug now as gtk+ seems fixed? And why weren't I cced?
Absolutely.
