Bug 233077 – Add QA check for respecting LDFLAGS

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2008-07-26 23:46:11 UTC]

Portage should contain QA check for respecting LDFLAGS.
This check should be run when LDFLAGS contain --hash-style=gnu, because files built with this flag don't contain .hash sections.
The check should be disabled for packages with ${PN}=*-bin.
The QA_DT_HASH variable can be set in ebuilds to avoid false positives.

[Comment 1 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2008-07-26 23:47:10 UTC]

Created attachment 161448 [details, diff]
Patch

[Comment 2 Zac Medico 2008-07-27 05:09:19 UTC]

This is great, thanks!

[Comment 3 Fabian Groffen 2008-07-27 09:25:16 UTC]

how about using
   if [[ " ${LDFLAGS} " == *" --hash-style=gnu "* ]] && ...
instead such that you're sure to only match hash-style "gnu"?

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2008-07-27 15:55:59 UTC]

(In reply to comment #3)
> how about using
>    if [[ " ${LDFLAGS} " == *" --hash-style=gnu "* ]] && ...
> instead such that you're sure to only match hash-style "gnu"?

It usually wouldn't match this flag.

[Comment 5 Zac Medico 2008-07-28 10:42:27 UTC]

This is fixed in 2.2_rc4.