Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 224787 - 256 colors support for x11-terms/rxvt-unicode
Summary: 256 colors support for x11-terms/rxvt-unicode
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: René Nussbaumer (RETIRED)
Depends on:
Reported: 2008-06-03 18:18 UTC by Pierre Guinoiseau
Modified: 2008-10-05 22:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

urxvt-256colors.diff (urxvt-256colors.diff,870 bytes, patch)
2008-06-03 18:18 UTC, Pierre Guinoiseau
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Guinoiseau 2008-06-03 18:18:07 UTC

there is a patch provided by upstream in the rxvt-unicode tarball to bring xterm's 256 colors into rxvt-unicode. I modified the ebuild to add a "colors256" use flag to apply the patch and activate this. Maybe we can find a better name for this use flag, i didn't know what would be the best.
I don't know if the ./ thing is really necessary, but I think it is because it modifies the file.

I would be cool to have it included in portage :)
Comment 1 Pierre Guinoiseau 2008-06-03 18:18:28 UTC
Created attachment 155401 [details, diff]

The ebuild patch
Comment 2 René Nussbaumer (RETIRED) gentoo-dev 2008-06-21 18:40:47 UTC
Thanks, I'll take care of this for the next release.
Comment 3 René Nussbaumer (RETIRED) gentoo-dev 2008-06-21 18:41:32 UTC
Do you've a more recent version than for 8.2?
Comment 4 Pierre Guinoiseau 2008-06-22 01:30:16 UTC
Yes, I have x11-terms/rxvt-unicode-9.02-r1
Comment 5 Pierre Guinoiseau 2008-06-23 13:26:32 UTC
I think I misunderstood your question, were you asking in fact about the patch version ? The supplied patch in rxvt-unicode is for the 8.2 version, but still works perfectly with the 9.*. In all cases, this is the patch supplied by upstream and included in the tarball, and this patch's version haven't changed. So, there is no problem in using it. :)
Comment 6 Anonymous bin ich 2008-08-29 07:10:43 UTC
Any idea when this will be in portage? Sorry for being impatient, I am on a dialup in a third world country, with a very low download cap.
Comment 7 Pierre Guinoiseau 2008-09-20 22:02:09 UTC
In fact, it seems that we should fix the terminfo file as well, like described in [1], but I don't know how to do it in the proper way in the ebuild...

Comment 8 Ben de Groot (RETIRED) gentoo-dev 2008-09-23 22:54:43 UTC
Call me impatient, but I didn't want to wait for this no longer, so I committed 9.05-r1 which has the 256color useflag. Enjoy!
Comment 9 Ben de Groot (RETIRED) gentoo-dev 2008-09-24 00:58:18 UTC
I have changed my mind and the logic in the ebuild, and apply the patch unless vanilla useflag is used, in response to bug 238526.
Comment 10 René Nussbaumer (RETIRED) gentoo-dev 2008-09-28 13:03:27 UTC
Yes, I call you impatient. This patch is not supported by upstream and may break urxvt. I'll reopen this, and adapt the build. The solution with vanilla is not the right approach. 

There's a problem open with xorg-server 1.5 which might be caused by this change and it breaks some vim colorschemes like inkpot.
Comment 11 René Nussbaumer (RETIRED) gentoo-dev 2008-10-04 12:57:19 UTC
Okay rxvt-unicode-9.05-r2 is in place which is nicer in this regard (you can select xterm-color for 256 color support and wcwidth for wide char support; independant). It also generates the new 256 color terminfo. This should also solve the problems, that rxvt-unicode in the 256 color version looks ugly on systems with a rxvt-unicode 88 color support.

Beside of that the patches are now marked as not supported by upstream.
Comment 12 Pierre Guinoiseau 2008-10-05 22:18:03 UTC
    use xterm-color || myconf="$myconf --enable-xterm-colors=256"
should be
    use xterm-color && myconf="$myconf --enable-xterm-colors=256"
I think :)