Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 238526 - rxvt-unicode 9.05-r1 can not apply patches based on conditions.
Summary: rxvt-unicode 9.05-r1 can not apply patches based on conditions.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: René Nussbaumer (RETIRED)
URL:
Whiteboard:
Keywords:
: 238531 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-09-24 00:10 UTC by Jory A. Pratt
Modified: 2008-12-21 03:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jory A. Pratt gentoo-dev 2008-09-24 00:10:08 UTC
>>> Unpacking source...
>>> Unpacking rxvt-unicode-9.05.tar.bz2 to /var/tmp/portage/x11-terms/rxvt-unicode-9.05-r1/work
 * Running eautoreconf in '/var/tmp/portage/x11-terms/rxvt-unicode-9.05-r1/work/rxvt-unicode-9.05' ...
 * Running autoconf ...                                                                                                                                                                                     [ ok ]
 * Running autoheader ...                                                                                                                                                                                   [ ok ]
>>> Source unpacked.
>>> Compiling source in /var/tmp/portage/x11-terms/rxvt-unicode-9.05-r1/work/rxvt-unicode-9.05 ...
 * econf: updating rxvt-unicode-9.05/config.guess with /usr/share/gnuconfig/config.guess
 * econf: updating rxvt-unicode-9.05/config.sub with /usr/share/gnuconfig/config.sub
./configure --prefix=/usr --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --enable-everything --enable-xft --disable-afterimage --enable-perl --disable-xterm-colors=256 --disable-text-blink --disable-iso14755 --libdir=/usr/lib64 --build=x86_64-pc-linux-gnu
configure: error: invalid feature name: xterm-colors=256
 * 
 * ERROR: x11-terms/rxvt-unicode-9.05-r1 failed.
 * Call stack:
 * ebuild.sh, line   49:  Called src_compile
 * environment, line 2871:  Called econf '--enable-everything' '--enable-xft' '--disable-afterimage' '--enable-perl' '--disable-xterm-colors=256' '--disable-text-blink' '--disable-iso14755'
 * ebuild.sh, line  541:  Called die
 * The specific snippet of code:
 * die "econf failed"
 * The die message:
 * econf failed
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/x11-terms/rxvt-unicode-9.05-r1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-terms/rxvt-unicode-9.05-r1/temp/environment'.
 * 

>>> Failed to emerge x11-terms/rxvt-unicode-9.05-r1, Log file:

>>>  '/var/tmp/portage/x11-terms/rxvt-unicode-9.05-r1/temp/build.log'


Reproducible: Always




Just remove use flags for patches, there is no need to apply based on useflag they just enable more features.
Comment 1 Ben de Groot (RETIRED) gentoo-dev 2008-09-24 00:56:10 UTC
You're right. I have changed the logic in the ebuild, and apply the patches unless vanilla useflag is used.
Comment 2 Jory A. Pratt gentoo-dev 2008-09-24 01:44:17 UTC
(In reply to comment #1)
> You're right. I have changed the logic in the ebuild, and apply the patches
> unless vanilla useflag is used.
> 

This is not the correct solution either. Apply the patch as upstream has already, then just use use_enable/use_with and allow user to still enable or disable the support. There is no need for the vanilla useflag at all as it does not properly support the function of enabling or disabling properly.
Comment 3 Jory A. Pratt gentoo-dev 2008-09-24 01:50:39 UTC
(In reply to comment #1)
> You're right. I have changed the logic in the ebuild, and apply the patches
> unless vanilla useflag is used.
> 

I should have also noted there is no need for the eautoreconf is no patches are applied. Sorry to have forgotten such a simple issue.
Comment 4 Jory A. Pratt gentoo-dev 2008-09-24 01:56:55 UTC
(In reply to comment #1)
> You're right. I have changed the logic in the ebuild, and apply the patches
> unless vanilla useflag is used.
> 

To make your job easier this is what ya should have done....


--- rxvt-unicode-9.05.ebuild	2008-06-21 13:18:07.000000000 -0500
+++ rxvt-unicode-9.05-r1.ebuild	2008-09-23 20:55:56.174965120 -0500
@@ -1,17 +1,17 @@
 # Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/x11-terms/rxvt-unicode/rxvt-unicode-9.05.ebuild,v 1.1 2008/06/21 18:18:07 killerfox Exp $
+# $Header: /var/cvsroot/gentoo-x86/x11-terms/rxvt-unicode/rxvt-unicode-9.05-r1.ebuild,v 1.2 2008/09/24 00:54:46 yngwin Exp $
 
-inherit flag-o-matic
+inherit autotools flag-o-matic
 
-DESCRIPTION="rxvt clone with XFT and Unicode support"
+DESCRIPTION="rxvt clone with xft and unicode support"
 HOMEPAGE="http://software.schmorp.de/"
 SRC_URI="http://dist.schmorp.de/rxvt-unicode/${P}.tar.bz2"
 
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
-IUSE="truetype perl iso14755 afterimage"
+IUSE="truetype perl iso14755 afterimage xterm-color"
 
 # see bug #115992 for modular x deps
 RDEPEND="x11-libs/libX11
@@ -26,25 +26,26 @@
 src_unpack() {
 	unpack ${A}
 	cd "${S}"
-	local tdir=/usr/share/terminfo
 
+	epatch doc/urxvt-8.2-256color.patch
+	epatch doc/wcwidth.patch
+
+	local tdir=/usr/share/terminfo
 	sed -i -e \
 		"s~@TIC@ \(\$(srcdir)/etc/rxvt\)~@TIC@ -o ${D}/${tdir} \1~" \
 		doc/Makefile.in
+
+	eautoreconf
 }
 
 src_compile() {
-	myconf=''
-
-	use iso14755 || myconf='--disable-iso14755'
-
-	econf \
-		--enable-everything \
+	econf --enable-everything \
 		$(use_enable truetype xft) \
 		$(use_enable afterimage) \
 		$(use_enable perl) \
+		$(use_enable iso14755) \
+		$(use_enable xterm-color xterm-colors=256) \
 		--disable-text-blink \
-		${myconf} \
 		|| die
 
 	emake || die
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2008-09-24 03:48:03 UTC
*** Bug 238531 has been marked as a duplicate of this bug. ***
Comment 6 Jory A. Pratt gentoo-dev 2008-12-21 03:13:08 UTC
This has been resolved already.