Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 202341 - dev-util/cflow: fix Emacs support
Summary: dev-util/cflow: fix Emacs support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 184166
  Show dependency tree
 
Reported: 2007-12-14 22:50 UTC by Ulrich Müller
Modified: 2007-12-15 01:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed changes for cflow-1.2.ebuild (cflow-1.2.ebuild.diff,992 bytes, patch)
2007-12-14 22:58 UTC, Ulrich Müller
Details | Diff
Emacs site-init file, goes to files/50cflow-gentoo.el (50cflow-gentoo.el,177 bytes, text/plain)
2007-12-14 22:59 UTC, Ulrich Müller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2007-12-14 22:50:50 UTC
cflow-1.2.ebuild doesn't byte-compile its Emacs Lisp files and uses the wrong eclass function (elisp-site-file-install instead of elisp-install) to install its Emacs support file.

A patch and a proper site-init file for Emacs will follow.
Comment 1 Ulrich Müller gentoo-dev 2007-12-14 22:58:01 UTC
Created attachment 138516 [details, diff]
Proposed changes for cflow-1.2.ebuild

Please note that Emacs support in the package's build system is unconditionally disabled; the compile and install functions of elisp-common.eclass are used instead. This is easier than tweaking the package's build system to honour the emacs USE flag.

elisp-site-regen should also be called in postrm.
Comment 2 Ulrich Müller gentoo-dev 2007-12-14 22:59:34 UTC
Created attachment 138518 [details]
Emacs site-init file, goes to files/50cflow-gentoo.el
Comment 3 Tiziano Müller (RETIRED) gentoo-dev 2007-12-15 00:12:40 UTC
looks gode. Go ahead and commit or wait until January (sorry, won't have time before the new year).
thanks anyway! :)
Comment 4 Ulrich Müller gentoo-dev 2007-12-15 01:42:36 UTC
Fixed in -r1.