Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 202205 - dev-scheme/guile-1.8.7: guile-config link reports CPPFLAGS and LDFLAGS it has been compiled with
Summary: dev-scheme/guile-1.8.7: guile-config link reports CPPFLAGS and LDFLAGS it has...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Marijn Schouten (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 335657
  Show dependency tree
 
Reported: 2007-12-14 00:16 UTC by Alexis Ballier
Modified: 2013-01-29 09:07 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
trivial patch (noldflag_in_guile_config.patch,885 bytes, patch)
2007-12-16 14:12 UTC, Alexis Ballier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2007-12-14 00:16:15 UTC
$ guile-config link
-pthread -lguile -lltdl -L/usr/lib64 -Wl,--as-needed -lgmp -lcrypt -lm -lltdl


I suppose the -Wl,--as-needed isnt wanted here
Comment 1 Marijn Schouten (RETIRED) gentoo-dev 2007-12-14 01:03:25 UTC
Does this cause any problems?
Comment 2 Alexis Ballier gentoo-dev 2007-12-14 09:54:46 UTC
(In reply to comment #1)
> Does this cause any problems?
> 

no, not really, but for example, I cant compile any program that uses guile-config link to link to guile without as-needed if I compiled guile with it. Not a big issue but still a bug imho.
Comment 3 Alexis Ballier gentoo-dev 2007-12-16 14:12:09 UTC
Created attachment 138613 [details, diff]
trivial patch

patch is trivial enough, but it's probably wiser to ask upstream if this has been done by intention or not.
If reporting compile time ldflags in guile-config link is the wanted behavior, then close as invalid but that sucks. If its not wanted, then this patch should do it.
Comment 4 Marijn Schouten (RETIRED) gentoo-dev 2007-12-16 15:06:07 UTC
sent upstream
Comment 5 Marijn Schouten (RETIRED) gentoo-dev 2008-02-17 14:02:23 UTC
Upstream says:
"if `-L' flags are passed through `$LDFLAGS' to `configure', like
`-L/path/to/gmp', then they must be reported by "guile-config link".

Admittedly, it has the undesirable side-effect of reporting completely
unrelated link flags as well.  Unfortunately, I'm not sure we could
reliably filter `$LDFLAGS'."
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-07 17:10:54 UTC
-L stuff _in general_ should be reported through LIBS actually. But at any rate, you don't even _need_ -L stuff when linking guile unless you are not on an ELF system, so they could easily use that to decide whether to import the full of LDFLAGS or not.

Or we could just fix it gentoo-side at least, as we know what is used to change libraries and what is just user configuration :)
Comment 7 Harald van Dijk (RETIRED) gentoo-dev 2010-04-24 10:43:59 UTC
It also reports the CPPFLAGS it has been compiled with in pkg-config --cflags, but it does not report the CFLAGS there.

And in my case, it does cause problems. I have emerge compile and link with extra flags that are not valid without a special specs file, so anything linking to guile outside of portage will complain about unrecognised compiler options.
Comment 8 Harald van Dijk (RETIRED) gentoo-dev 2010-04-24 10:45:51 UTC
Actually, I only noticed this with guile 1.8.7; adjusting summary since it's possible that 1.8.3 did not record CPPFLAGS, which would make the summary confusing.
Comment 9 Marijn Schouten (RETIRED) gentoo-dev 2010-11-29 10:50:17 UTC
Harald, do you have a patch that solves the issue for you?
Comment 10 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-01-30 22:40:33 UTC
For the record, it was mandatory to workaround this at least for LDFLAGS in gnucash 2.4 [1] ebuild or a majority of tests would fail.

[1] bug #346919
Comment 11 Panagiotis Christopoulos (RETIRED) gentoo-dev 2011-03-26 22:43:30 UTC
(In reply to comment #10)
> For the record, it was mandatory to workaround this at least for LDFLAGS in
> gnucash 2.4 [1] ebuild or a majority of tests would fail.
> 
> [1] bug #346919

Guys, I want to ask stabilization of guile-1.8.8. Is there something you want me to do before that? Alexis patch is very simple, do you still want me to apply it?
Comment 12 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-03-26 23:54:42 UTC
If it fixes what's reported by guile-config and by pkgconfig, then it would sure fit our needs.
Comment 13 Panagiotis Christopoulos (RETIRED) gentoo-dev 2011-04-29 14:21:34 UTC
@@ -2,6 +2,13 @@
 # Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
 # $Header: /var/cvsroot/gentoo-x86/dev-scheme/guile/ChangeLog,v 1.84 2011/04/29 09:44:07 pchrist Exp $
 
+*guile-1.8.8-r1 (29 Apr 2011)
+
+  29 Apr 2011; Panagiotis Christopoulos <pchrist@gentoo.org>
+  +guile-1.8.8-r1.ebuild, +files/guile-1.8.8-fix_guile-config.patch:
+  revbump, first try to fix bug #202205. Fix based on old patch from Alexis
+  Ballier (aballier)
+

This should be fixed in 1.8.8-r1. Please, test and report. I will soon file a stabilization request for 1.8.8-r1 if we don't have problems, and I'll do some cleanup of the whole directory/ebuilds.
Comment 14 Cyprien Nicolas (fulax) 2013-01-29 09:07:31 UTC
dev-scheme/guile-1.8.8-r1 has been stabled. Closing.