Bug 182056 – sci-visualization/epix: include epix.el with emacs use flag

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jukka Ruohonen 2007-06-14 20:35:58 UTC]

After installing the great epix-1.0.24 for the first time, I noticed that the Jay Belanger's major mode for editing ePiX files with emacs gets installed into /usr/share/doc/epix-1.0.24/config/epix.el. 

Thus, it would be nice if we would have emacs-capability with an USE flag.

[Comment 1 Christian Faulhammer (RETIRED) 2007-06-25 07:37:33 UTC]

Created attachment 123024 [details, diff]
patch to add Emacs support and activate bash-completion

Here is a patch that will add optional Emacs support and optional installation of bash-completion.  Site file will follow.

[Comment 2 Christian Faulhammer (RETIRED) 2007-06-25 07:39:33 UTC]

Created attachment 123025 [details]
site file, to go to ${FILESDIR}

This will autoload the elisp files when needed

[Comment 3 Christian Faulhammer (RETIRED) 2007-09-09 14:17:45 UTC]

Dear sci team, when bumping, please add us to your prayers and fix the emacs support, everything is here in form of patches.  Thanks.

[Comment 4 Markus Dittrich (RETIRED) 2007-09-10 10:53:48 UTC]

Hi Christian,

Since I don't use emacs, could you please let me know if
these patches work smoothly with epix 1.1.15 which is
now in portage. If so, I'd gladly add it to the ebuild.

Thanks much for the good emacs work.

cheers,
Markus

[Comment 5 Christian Faulhammer (RETIRED) 2007-09-10 17:02:14 UTC]

(In reply to comment #4)
> Since I don't use emacs,

 You are doing badly wrong here. :)

> could you please let me know if
> these patches work smoothly with epix 1.1.15 which is
> now in portage. If so, I'd gladly add it to the ebuild.

 No, it won't work.  I will prepare a new patch, Emacs support has been changed a lot. 

> Thanks much for the good emacs work.

 That's just team work.

> cheers,
> Markus

 Christian

[Comment 6 Christian Faulhammer (RETIRED) 2007-09-10 17:47:00 UTC]

Created attachment 130523 [details]
patch to add Emacs support

Ok, bash_completion is gone.  I exchanged a generic make call by emake, it worked here, so maybe you tend to add it.

[Comment 7 Markus Dittrich (RETIRED) 2007-09-11 01:34:24 UTC]

(In reply to comment #6)
 > Ok, bash_completion is gone.  I exchanged a generic make call by emake, it
> worked here, so maybe you tend to add it.
> 

Thanks much - I just commited the patch to cvs.
It seems though that emacs is already needed
during the compile itself, so should virtual/emacs
rather go into DEPEND?

Thanks,
Markus

[Comment 8 Christian Faulhammer (RETIRED) 2007-09-11 06:00:14 UTC]

(In reply to comment #7)
> (In reply to comment #6)
>  > Ok, bash_completion is gone.  I exchanged a generic make call by emake, it
> > worked here, so maybe you tend to add it.
> > 
> Thanks much - I just commited the patch to cvs.
> It seems though that emacs is already needed
> during the compile itself, so should virtual/emacs
> rather go into DEPEND?

 You are right.

[Comment 9 Markus Dittrich (RETIRED) 2007-09-11 13:34:38 UTC]

Thanks, I've changed the ebuild accordingly.

[Comment 10 Jukka Ruohonen 2007-09-13 07:34:14 UTC]

Hi, thanks for your efforts. 

Unfortunately, as you probably noticed, the USE="emacs" fails; see bug #192283.