genlop understands more arguments than the bash_completion script now supports. I added them (and cleaned up the code a little :-) ) Reproducible: Always Steps to Reproduce: e.g. type "genlop --d" and hit TAB Actual Results: nothing changes Expected Results: genlop --date
Created attachment 70930 [details, diff] support for more command-line arguments This patch adds support for one-letter arguments and --date. It fixes the "unary operator expected" bug. I got that message every time I hit TAB. The bug happened here: if [ ${portagedir} = "" ] Cleaned up the code a little, so that it uses bash-internal [[ ... ]] instead of [ ... ] for conditions.
genlop has it's own bash completion from upstream so reassigning this to the genlop maintainers.
btw, while I'm here, one thing that's always bugged me about their completion is they use 'cd' instead of 'builtin cd'. Otherwise folks who have cd redefined to display stuff upon entering a directory (todo lists in my case) get their completion messed up due to the ouput. Can we get that fixed as well?
Created attachment 70941 [details, diff] changes 'cd' to 'builtin cd'
(In reply to comment #3) > btw, while I'm here, one thing that's always bugged me about their completion is > they use 'cd' instead of 'builtin cd'. Otherwise folks who have cd redefined to > display stuff upon entering a directory (todo lists in my case) get their > completion messed up due to the ouput. Can we get that fixed as well? I'm wondering, is it possible to define a global alias cd='builtin cd' instead of writing 'builtin cd' in every completion function? It should be seen only by all the bash_completion scripts, of course.
Created attachment 121795 [details, diff] combined patch for genlop 0.30.7 I've updated the patches to the latest version (0.30.7) of genlop.
(In reply to comment #6) > Created an attachment (id=121795) [details] > combined patch for genlop 0.30.7 > > I've updated the patches to the latest version (0.30.7) of genlop. > Thanks for the patch Renet. I'm not sure why this has not been addressed by the tools-portage team. Here is a friendly poke, as it probably slipped through the cracks :)
Thanks for the patch, released in genlop-0.30.9