Bug 923369 – app-portage/gentoolkit-0.6.5: document eclean-dist --skip-vcs

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Enne Eziarc 2024-01-31 01:26:53 UTC]

I export $DISTDIR over NFS to several machines and rely on eclean-dist (*without* --deep) to leave those files intact. Today I ran it and instantly lost several gigabytes of distfiles I was actively using. As I'm behind a slow ISP connection, recovering from the data loss will take the better part of a day.

This is a severe bug and/or surprising new behaviour that directly contradicts the eclean(1) manpage.

[Comment 1 Mike Gilbert 2024-01-31 01:34:52 UTC]

You can run eclean-dist --skip-vcs to avoid it.

[Comment 2 Sam James 2024-05-03 05:47:19 UTC]

Yeah, two bugs here, really:
1) Not documenting --skip-vcs;
2) Incorrect description of behaviour / --skip-vcs contradicting --deep

I'll fix both now.

[Comment 3 Larry the Git Cow 2024-05-03 05:55:02 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=d6fa2944ed84266acbaef59cb6d3adbd35d372b1

commit d6fa2944ed84266acbaef59cb6d3adbd35d372b1
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-03 05:46:10 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-03 05:46:10 +0000

    man: document eclean-dist's --skip-vcs
    
    Bug: https://bugs.gentoo.org/923369
    Signed-off-by: Sam James <[e-mail]>

 man/eclean.1 | 2 ++
 1 file changed, 2 insertions(+)

[Comment 4 Larry the Git Cow 2024-05-03 06:18:17 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=ada43fcd4306b1dac26606058ef97399beaa360a

commit ada43fcd4306b1dac26606058ef97399beaa360a
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-03 06:06:22 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-03 06:18:10 +0000

    eclean: dist: make VCS cleaning dependent on --deep
    
    The man page clearly says that without --deep, users can expect eclean-dist
    to be conservative in cleaning up, and not consider the VDB, just the repo
    state.
    
    Honour that promise by making VCS cleaning dependent on --deep, given it
    involves VDB inspection to see what's installed.
    
    Bug: https://bugs.gentoo.org/923369
    Signed-off-by: Sam James <[e-mail]>

 man/eclean.1                 | 1 +
 pym/gentoolkit/eclean/cli.py | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

[Comment 5 Larry the Git Cow 2024-05-08 21:44:59 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1

commit 7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1
Author:     Sam James <[e-mail]>
AuthorDate: 2024-05-08 21:44:38 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-05-08 21:44:38 +0000

    app-portage/gentoolkit: add 0.6.7
    
    Closes: https://bugs.gentoo.org/877491
    Closes: https://bugs.gentoo.org/923369
    Closes: https://bugs.gentoo.org/915055
    Closes: https://bugs.gentoo.org/928951
    Closes: https://bugs.gentoo.org/928138
    Signed-off-by: Sam James <[e-mail]>

 app-portage/gentoolkit/Manifest                |   1 +
 app-portage/gentoolkit/gentoolkit-0.6.7.ebuild | 127 +++++++++++++++++++++++++
 2 files changed, 128 insertions(+)