Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 915055

Summary: app-portage/gentoolkit-0.6.1-r3: rerun of eclean-dist -d results in UnboundLocalError
Product: Gentoo Linux Reporter: Erik Quaeghebeur <gentoo>
Component: Current packagesAssignee: Portage Tools Team <tools-portage>
Status: RESOLVED FIXED    
Severity: normal Keywords: InVCS, PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: fix-verb.patch

Description Erik Quaeghebeur 2023-10-01 21:00:10 UTC
I have app-portage/gentoolkit-0.6.1-r3 installed. I ran

# eclean-dist -dp
…
# eclean-dist -d
…
# eclean-dist -dp

The last call resulted in the following output:
---
 * Building file list for distfiles cleaning...
 * Your distfiles directory was already clean.

   The following unavailable files were saved from cleaning due to exclusion file entries
 [   80.6 M ] teams_1.4.00.26453_amd64.deb
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.11/eclean-dist", line 41, in <module>
    main()
  File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/cli.py", line 679, in main
    doAction(action, options, exclude=exclude, output=output)
  File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/cli.py", line 599, in doAction
    output.total("deprecated", clean_size, len(saved), verb, action)
                                                       ^^^^
UnboundLocalError: cannot access local variable 'verb' where it is not associated with a value
---
So it seems there is some bug in eclean. 

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-02 17:23:52 UTC
Created attachment 872049 [details, diff]
fix-verb.patch

Untested, but this looks like it'll do it.
Comment 2 Larry the Git Cow gentoo-dev 2024-05-03 05:42:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=7a5a2f540bc4776121d08d331b141d897eac92f6

commit 7a5a2f540bc4776121d08d331b141d897eac92f6
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-03 05:41:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-03 05:41:46 +0000

    eclean: dist: fix crash with excluded items
    
    Bug: https://bugs.gentoo.org/915055
    Signed-off-by: Sam James <sam@gentoo.org>

 pym/gentoolkit/eclean/cli.py | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Larry the Git Cow gentoo-dev 2024-05-08 21:44:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1

commit 7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-08 21:44:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-08 21:44:38 +0000

    app-portage/gentoolkit: add 0.6.7
    
    Closes: https://bugs.gentoo.org/877491
    Closes: https://bugs.gentoo.org/923369
    Closes: https://bugs.gentoo.org/915055
    Closes: https://bugs.gentoo.org/928951
    Closes: https://bugs.gentoo.org/928138
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/gentoolkit/Manifest                |   1 +
 app-portage/gentoolkit/gentoolkit-0.6.7.ebuild | 127 +++++++++++++++++++++++++
 2 files changed, 128 insertions(+)