Summary: | games-engines/qtads-1.9.ebuild: version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Nikos Chantziaras <realnc> |
Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | cycoone, levertond, tech31842 |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://qtads.sf.net | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
qtads-1.7.ebuild
qtads-1.7.ebuild qtads-1.7.ebuild.patch qtads-1.8.ebuild |
Description
Nikos Chantziaras
2008-04-11 22:53:35 UTC
Created attachment 149442 [details]
qtads-1.7.ebuild
QTads, along with many other IF tools, is now in the "interactive-fiction" overlay. It can be easily accessed with the "layman" utility. Thanks to David Leverton for the overlay. Should we CC Michael about this? Depends on who Michael is :P Michael Sterrett aka Mr. Bones. He seems to have done the initial commit and most of the maintenance thus far. Mr. Bones is member of games herd. Thus he gets every change added to games@gentoo.org alias. Read as: he already see this stuff on his mail :] no need to cc him additionaly. With that he only gets double mails :] Created attachment 191422 [details] qtads-1.7.ebuild Here's a new ebuild, this time doing it "the right way" (I hope). * Uses EAPI version 2. * DEPEND uses slotted Qt. * Uses append-cxxflags instead of CXXFLAGS directly. * Installs using emake instead of by hand with doins (except for the docs and translations.) * Supports LINGUAS to determine whether translations should be installed. * Removes src_compile() and introduces src_configure() where eqmake3 should be. * Adds a desktop entry. It's written from scratch again so a patch would be longer than the original ebuild. The ebuild results in a "QA Notice: Pre-stripped files found" message, but instead of fixing this in the ebuild, I decided to fix it portage-wide for all qmake projects and therefore submitted bug 269942. It's just a matter of passing "QMAKE_STRIP=" to qmake but this should go in qt3.eclass instead of in every ebuild that makes use of eqmake3. (In reply to comment #7) > Created an attachment (id=191422) [edit] > qtads-1.7.ebuild > > Here's a new ebuild, this time doing it "the right way" (I hope). Updated in the overlay. The only thing that I noticed that's slightly wrong is ${A} being quoted. It doesn't really hurt here because there's only one source file (if there were more, they'd be passed as a single argument to unpack containing spaces), but it's better to leave it unquoted. (In reply to comment #8) > Updated in the overlay. The only thing that I noticed that's slightly wrong is > ${A} being quoted. It doesn't really hurt here because there's only one source > file (if there were more, they'd be passed as a single argument to unpack > containing spaces), but it's better to leave it unquoted. Oops, thanks for catching this. I suppose you changed it before committing it. (In reply to comment #9) > Oops, thanks for catching this. I suppose you changed it before committing it. Well, I've been trying not to introduce needless differences between the overlay and the ebuild here, especially over something that doesn't make a practical difference, since it would probably lead to confusion (my own, if no-one else's). But I'll update it now. Created attachment 191427 [details, diff]
qtads-1.7.ebuild.patch
I asked since I'm now attaching a patch for the ebuild in case this gets into Portage ;)
Created attachment 192521 [details]
qtads-1.8.ebuild
New upstream release: 1.8
This ebuild incorporates the previous patch and also fixes the call to make_desktop_entry.
New upstream release: version 1.9. Renaming the 1.8 ebuild works. If possible, please either bump the version in Portage to this version or completely remove the (now ancient) version 1.6c from Portage since it doesn't even work anymore for TADS3 games released after 2005. qtads-1.9 is in portage. (In reply to comment #14) > qtads-1.9 is in portage. I'm reopening because it seems you used the wrong ebuild :P The correct ebuild is the last one posted here (qtads-1.8.ebuild, must be renamed to qtads-1.9.ebuild). this bug was about the version bump. If there's patches necessary against the one in portage please open a new bug. *** Bug 245156 has been marked as a duplicate of this bug. *** |