Summary: | [Tracker] USE-flag cleanup | ||
---|---|---|---|
Product: | Quality Assurance | Reporter: | Elias Probst <mail> |
Component: | Trackers | Assignee: | Gentoo Quality Assurance Team <qa> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | betelgeuse, drizzt, gengor, roman.zilka, tinaught |
Priority: | High | Keywords: | Tracker |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 198901, 94756, 134493, 134645, 144534, 148416, 157265, 158114, 166759, 177657, 178128, 202967 | ||
Bug Blocks: | |||
Attachments: |
unused local flags
unused local flags (updated) unused local flags (updated again) Usage of global flags by unmasked packages Usage of local-only flags by packages Usage of global flags by unmasked packages |
Description
Elias Probst
2006-05-27 03:17:24 UTC
Created attachment 96469 [details]
unused local flags
CCing maintainers/herds, please pick up your stuff from the above list and clean up, thanks. magma-plugins fixed dovecot fixed gnustep-base/gnustep-base: use.local.desc unused flag(s): libffi thanks, I forgot this one indeed. kde, media-video, sound, bsd done. The following useflags have been removed (thus fixed) from use.local.desc: net-wireless/ipw2200: radiotap (myself) net-wireless/ipw3945: radiotap (myself) sys-apps/lm_sensors: rrdtool (myself) sys-kernel/ck-sources: ck-plus (kernel) sys-kernel/vserver-sources: ngnet (vserver-devs) xmerlin removed nogulm (sys-cluster/magma-plugins). In the future, it would be more helpful if you could list by maintainer rather than package. Mozilla stuff cleaned up. xen fixed. mail-filter/spamassassin: use.local.desc unused flag(s): extramodules, pyzor, razor, spf extramodules was taken care of when this was first mentioned on -dev, and the rest is still a false finding. The other three flags are still being used by one of the ebuilds for spamassassin. Fix your list :) (In reply to comment #11) > extramodules was taken care of when this was first mentioned on -dev, and the > rest is still a false finding. The other three flags are still being used by > one of the ebuilds for spamassassin. Fix your list :) > blame my reply on being up for 46 hours or something...use.local.desc looks fixed, taking perl off this list, sorry for the traffic Fixed app-misc/workrave flags Created attachment 96568 [details]
unused local flags (updated)
Attached an updated list to make search easier... ;)
Removed dev-java/ibm-jre-bin, dev-java/velocity and nogecko-sdk from dev-util/eclipse-sdk. fixed gnash, acroread, madwifi, pcmcia fixed the net-im/gossip entry Fixed dev-ml/ocamlsdl. Fixed media-sound/bmpx: amazon beagle, banshee, bonfire and rhythmbox done. cyrus-sasl done. gnome-extra/sensors-applet fixed. The old code that used the termcap-compat has been removed from the vim.eclass (it only affected IUSE, DEPEND, and src_compile, not anything called at unmerge). The entries have been removed from use.local.desc. Created attachment 97225 [details]
unused local flags (updated again)
What's left? app-text/poppler: use.local.desc unused flag(s): cairo there is no poppler in use.local.desc printing fixed dev-db/mysql-community: use.local.desc unused flag(s): raid media-plugins/vdr-audiorecorder: use.local.desc unused flag(s): taglib media-video/dvdrip: use.local.desc unused flag(s): rar media-video/vdr: use.local.desc unused flag(s): rcu, rds-timeout, vfat net-wireless/rt2x00: use.local.desc unused flag(s): eeprom cleanup for media-plugins/vdr-audiorecorder: use.local.desc unused flag(s): taglib media-video/vdr: use.local.desc unused flag(s): rcu, rds-timeout, vfat done ;; Someone removed eeprom from rt2x00 app-misc/lirc: use.local.desc unused flag(s): streamzap dev-db/mysql: use.local.desc unused flag(s): pbxt, srvdir dev-db/mysql-community: use.local.desc unused flag(s): raid, srvdir dev-db/mysql-slotted: use.local.desc unused flag(s): srvdir mail-client/mozilla-thunderbird: use.local.desc unused flag(s): mozcalendar, moznoxft net-misc/nxserver-business: use.local.desc unused flag(s): prebuilt net-misc/nxserver-enterprise: use.local.desc unused flag(s): prebuilt net-misc/nxserver-personal: use.local.desc unused flag(s): prebuilt sci-geosciences/grass: use.local.desc unused flag(s): proj sys-apps/paludis: use.local.desc unused flag(s): gems sys-freebsd/freebsd-bin: use.local.desc unused flag(s): rcp xfce-base/thunar: use.local.desc unused flag(s): freetype dev-libs/g-wrap: use.local.desc unused flag(s) glib net-ftp/proftpd: use.local.desc unused flag(s) sendfile sys-cluster/util-vserver: use.local.desc unused flag(s) legacy sys-cluster/vzctl: use.local.desc unused flag(s) udev www-servers/tomcat: use.local.desc unused flag(s) jni x11-base/xorg-x11: use.local.desc unused flag(s) GAPING_SECURITY_HOLE, bitmap-fonts, dlloader, dmx, font-server, insecure-drivers, sdk, truetype-fonts, type1-fonts xfce-base/thunar: use.local.desc unused flag(s) freetype xfce-extra/xarchiver: use.local.desc unused flag(s) ace, rpm (In reply to comment #31) > sys-cluster/util-vserver: use.local.desc unused flag(s) legacy > sys-cluster/vzctl: use.local.desc unused flag(s) udev > sys-cluster/vserver-utils: use.local.dec (no longer in the tree) All above fixed. All fix0rated! (The xfce ones, at least) The rest fixed by mr_bones app-cdr/cdrtools: use.local.desc unused flag(s) on-the-fly-crypt dev-java/hibernate: use.local.desc unused flag(s) c3p0, dbcp, jboss, jcs, oscache, swarmcache mail-client/squirrelmail: use.local.desc unused flag(s) virus-scan media-sound/mumble: use.local.desc unused flag(s) pch net-wireless/linux-wlan-ng-modules: use.local.desc unused flag(s) pci, plx use.desc unused flag(s): gb, ovrimos nothing to do for web-apps app-crypt/ccid: use.local.desc unused flag(s) chipcard2 app-editors/emacs-cvs: use.local.desc unused flag(s) aqua dev-db/postgresql: use.local.desc unused flag(s) pg-vacuumdelay mail-mta/qmail-ldap: use.local.desc unused flag(s) controldb net-fs/samba: use.local.desc unused flag(s) ldapsam, libclamav net-www/apache: use.local.desc unused flag(s) lingerd sys-kernel/suspend2-sources: use.local.desc unused flag(s) ultra1 sys-libs/libvserver: use.local.desc unused flag(s) diet sys-power/hibernate-script: use.local.desc unused flag(s) vim www-client/mozilla-launcher: use.local.desc unused flag(s) aoss dev-db/postgresql: use.local.desc unused flag(s) pg-hier, pg-vacuumdelay net-fs/samba: use.local.desc unused flag(s) ldapsam, libclamav ... done app-editors/emacs-cvs: use.local.desc unused flag(s) aqua Fixed. www-client/mozilla-launcher: use.local.desc unused flag(s) aoss Done (In reply to comment #35) > app-cdr/cdrtools: use.local.desc unused flag(s) on-the-fly-crypt Somebody must have removed that already. Thanks! done: sys-power/hibernate-script app-crypt/ccid sys-kernel/suspend2-sources All vserver related packages were already fixed. apache related ebuilds fixed qmail-ldap already fixed I was bored today. For each global flag I made a list of packages that have at least one package version in the tree that 1. isn't masked (be it hard or ~arch) and 2. uses this flag. $ for i in `cat use.desc |cut -d ' ' -f1`; do echo "-------- $i"; equery -Cq h -pF '$mask $cp' $i | egrep -v '(^M|~)' | sort | uniq -s 3 | tee /tmp/globals/$i; done A tarball of the directory 'globals' is attached (please ignore the occasional dash in front of a package name). As 'wc -l' reveals, there is quite a number of flags that are used by very few packages (even zero). You might want to consider making these local flags. Similarly, I made a list of local flags that are not global at the same time. For every such flag I counted the packages that use this flag. By "use" in this case I mean that they are listed in use.local.desc (could be masked versions of packages this time). See another attachment. Again, there are a few dozen flags that are used by >=10 packages. This is something that the user should be told about. I assume that a lot of users only notice global flags more thoroughly, because they assume that those are the ones that will matter most - affect the most packages. A similar argument supports making the scarce global flags local. An incrementally obfuscated method for getting the second list (might need checking for errors): # cat use.desc |cut -d ' ' -f1 > globals # cat use.local.desc |sed 's/^[^:]*:\([^ ]*\) .*$/\1/'|sort|uniq|diff - globals |grep '^<'|cut -d ' ' -f2 |sed 's/\(.*\)/:\1 - /' >locals-that-are-not-global # cat use.local.desc |grep -f locals-that-are-not-global |sed 's/^[^:]*:\([^ ]*\) .*$/\1/'|sort|uniq -c|sort -n >locals-that-are-not-global2 Created attachment 336600 [details]
Usage of global flags by unmasked packages
Usage of global flags by unmasked packages
Created attachment 336602 [details]
Usage of local-only flags by packages
Created attachment 336742 [details]
Usage of global flags by unmasked packages
A better version: this time with /etc/portage/package.* removed and ACCEPT_KEYWORDS="alpha amd64 arm hppa ia64 m68k mips ppc ppc64 s390 sh sparc x86 sparc-fbsd x86-fbsd". Still, hardmasks (that are filtered out) are based on hardened amd64, where I made the lists. Might need merging with results from non-hardened x86 and perhaps ppc, but the difference won't be huge, I suppose.
|