Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134493 - USE-flag cleanup: noamazon/amazon
Summary: USE-flag cleanup: noamazon/amazon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 134491
  Show dependency tree
 
Reported: 2006-05-27 03:25 UTC by Elias Probst
Modified: 2007-10-11 17:00 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2006-05-27 03:25:34 UTC
The USE-flags
amazon (Local Flag: Enable Amazon album cover fetching (media-sound/bmpx))
and
noamazon (Local Flag: Disable support for downloading covers from amazon.com (media-sound/amarok))
do nearly the same.
Maybe we could invert the behaviour of one of this flag to reduce the usage either to "amazon" or to "noamazon".

Packages affected by "amazon":
	media-sound/bmpx
Packages affected by "noamazon":
	media-sound/amarok
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-05-28 10:03:46 UTC
If this would be changed to amazon, I would ask for it to be enabled by default.

chutzpah, thoughts?
Comment 2 Patrick McLean gentoo-dev 2006-05-28 11:56:38 UTC
Should be fine to enable it by default, generally it's nicer to avoid "no*" flags.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2006-12-07 09:08:27 UTC
bmpx is gone from this bug, there is no such USE flag anymore but..

[-    ] amazon (media-sound/lastfm-ripper):
Enable advanced tagging using amazon webservices

[-    ] noamazon (media-sound/amarok):
Disable support for downloading covers from amazon.com

Problem has moved to lastfm-ripper vs. amarok now.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2006-12-07 09:14:36 UTC
Hi pclouds, since you are maintainer of lastfm-ripper.. what do you think?
Comment 5 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev 2006-12-07 11:16:23 UTC
I'd prefer amazon over noamazon. As last.fm-ripper can work well without Amazon web services, I'd rather disable it by default. If Amarok's Amazon feature can be enabled by default without affecting last.fm-ripper, I have no complaint.
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-07-12 13:39:59 UTC
Ping!
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2007-07-12 14:22:13 UTC
(In reply to comment #6)
> Ping!
> 

Ping to who? Amarok and KDE people aren't even CCd here. 

Now they are.
Comment 8 Jorge Manuel B. S. Vicetto (RETIRED) Gentoo Infrastructure gentoo-dev 2007-08-11 16:41:53 UTC
Diego, can you please look at this bug again?
Thanks.
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-10-04 20:02:18 UTC
Can someone finally do this?
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2007-10-11 17:00:15 UTC
noamazon USE flag has now been replaced by amazon, and it's enabled by default in base/package.use wrt Comment #1.

Closing.