Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 951100 - media-gfx/imagemagick (all current versions) ebuild fails with Usage: addpredict <colon-delimited list of paths>
Summary: media-gfx/imagemagick (all current versions) ebuild fails with Usage: addpred...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Codec Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-10 05:48 UTC by Ben
Modified: 2025-03-10 06:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben 2025-03-10 05:48:58 UTC
When building media-gfx/imagemagick I get:

 * Running elibtoolize in: ImageMagick-7.1.1-38/
 * Running elibtoolize in: ImageMagick-7.1.1-38/config/
 *   Applying portage/1.2.0 patch ...
 *   Applying sed/1.5.6 patch ...
 *   Applying as-needed/2.5.0 patch ...
 *   Applying verbose-pic/2.4.7 patch ...
 *   Applying clang-runtime-ltmain/2.4.7 patch ...
 * ERROR: media-gfx/imagemagick-7.1.1.38-r2::gentoo failed (prepare phase):
 *   Usage: addpredict <colon-delimited list of paths>
 * 
 * Call stack:
 *     ebuild.sh, line  136:  Called src_prepare
 *   environment, line 2491:  Called addpredict ''
 *     ebuild.sh, line  174:  Called __sb_append_var 'PREDICT' ''
 *     ebuild.sh, line  165:  Called die

It appears a stealth change/unbumped -r rev in all imagemagick-*.ebuilds in current portage changed the detection of /dev/dri/card* to addpredict from a test to a for loop.  However I think the for loop without the test -n passes ungroked *'s if the entry doesn't exist and causes addpredict to barf.

I reverted the change in my local overlay and it allowed the package to build.  All versions appear to be affected at least my last/current copy of the tree.  

Reproducible: Always

Steps to Reproduce:
1. emerge imagemagick # (any current version)
2.
3.
Actual Results:  
src_prepare fails with Usage: addpredict <colon-delimited list of paths> 

Expected Results:  
ebuild should merge...
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-03-10 06:02:42 UTC
That would be:

commit d8b3a440d5094cccf9be4f2f0df11dd79c869828
Author: Sam James <sam@gentoo.org>
Date:   Fri Jan 24 04:56:16 2025 +0000

    media-gfx/imagemagick: fix addpredict use

    Newer Portage bans use of colons in addpredict calls.

    Signed-off-by: Sam James <sam@gentoo.org>

But hardly a stealth change, it was fatal without it anyway with newer Portage.

The issue is the quoting vs nullglob.
Comment 2 Larry the Git Cow gentoo-dev 2025-03-10 06:08:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=daeee4faff3eeb8bfb7839735d6cccb38a19ea43

commit daeee4faff3eeb8bfb7839735d6cccb38a19ea43
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-10 06:04:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-10 06:07:35 +0000

    media-gfx/imagemagick: fix nullglob vs quoting
    
    Closes: https://bugs.gentoo.org/951100
    Fixes: d8b3a440d5094cccf9be4f2f0df11dd79c869828
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/imagemagick/imagemagick-6.9.13.16-r1.ebuild | 8 ++++----
 media-gfx/imagemagick/imagemagick-6.9.13.3.ebuild     | 8 ++++----
 media-gfx/imagemagick/imagemagick-7.1.1.25-r1.ebuild  | 8 ++++----
 media-gfx/imagemagick/imagemagick-7.1.1.38-r2.ebuild  | 8 ++++----
 media-gfx/imagemagick/imagemagick-9999.ebuild         | 8 ++++----
 5 files changed, 20 insertions(+), 20 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4fb9adcd287b12f72cf840146a428cd9e12fdd2

commit a4fb9adcd287b12f72cf840146a428cd9e12fdd2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-10 06:07:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-10 06:07:36 +0000

    sci-geosciences/grass: fix nullglob vs quoting
    
    Bug: https://bugs.gentoo.org/951100
    Bug: https://bugs.gentoo.org/948968
    Fixes: 0498e6fbc8a5a9c53234d125fc36f3941635c7b5
    Fixes: d8b3a440d5094cccf9be4f2f0df11dd79c869828
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-geosciences/grass/grass-8.3.2-r1.ebuild  | 8 ++++----
 sci-geosciences/grass/grass-8.4.0.ebuild     | 8 ++++----
 sci-geosciences/grass/grass-8.4.1.ebuild     | 8 ++++----
 sci-geosciences/grass/grass-8.4.1_rc1.ebuild | 8 ++++----
 sci-geosciences/grass/grass-9999.ebuild      | 8 ++++----
 5 files changed, 20 insertions(+), 20 deletions(-)