Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 948968 - sci-geosciences/grass fails compile: addpredict argument must not contain a colon
Summary: sci-geosciences/grass fails compile: addpredict argument must not contain a c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: mario.haustein
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2025-01-28 17:23 UTC by tdr
Modified: 2025-03-10 06:08 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for all versions of grass presently in portage (grass-fix-addpredict-arg-error.patch,7.25 KB, patch)
2025-01-28 18:03 UTC, tdr
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tdr 2025-01-28 17:23:23 UTC
src_prepare section needs reworked for section "# For testsuite, see https://bugs.gentoo.org/show_bug.cgi?id=500580#c3" 



Reproducible: Always

Actual Results:  
>>> Emerging (74 of 171) sci-geosciences/grass-8.4.0::gentoo
 * grass-8.4.0.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                                                           [ ok ]
 * Using python3.12 to build
>>> Unpacking source...
>>> Unpacking grass-8.4.0.tar.gz to /var/tmp/portage/sci-geosciences/grass-8.4.0/work
>>> Source unpacked in /var/tmp/portage/sci-geosciences/grass-8.4.0/work
>>> Preparing source in /var/tmp/portage/sci-geosciences/grass-8.4.0/work/grass-8.4.0 ...
 * Applying grass-flock.patch ...                                                                                                                                           [ ok ]
 * Fixing python shebangs ...                                                                                                                                               [ ok ]
 * ERROR: sci-geosciences/grass-8.4.0::gentoo failed (prepare phase):
 *   addpredict argument must not contain a colon
 *
 * Call stack:
 *     ebuild.sh, line  136:  Called src_prepare
 *   environment, line 2756:  Called addpredict '/dev/dri/card0:/dev/dri/card1:/dev/dri/renderD128:/dev/dri/renderD129'
 *     ebuild.sh, line  175:  Called __sb_append_var 'PREDICT' '/dev/dri/card0:/dev/dri/card1:/dev/dri/renderD128:/dev/dri/renderD129'
 *     ebuild.sh, line  166:  Called die
 * The specific snippet of code:
 *   	[[ ${1} == *:* ]] && die "add${_v,,} argument must not contain a colon"


section is similar to what was needed for imagemagick.  will attach patch for builds
Comment 1 tdr 2025-01-28 18:03:38 UTC
Created attachment 917733 [details, diff]
patch for all versions of grass presently in portage

tested on grass-8.3.2-r1.ebuild  grass-8.4.0.ebuild  grass-9999.ebuild
all built successful  (=grass-8.3.2-r1 needs gnustd17  in my choort but that's another issue)
Comment 2 Martin Mokrejš 2025-02-18 14:00:30 UTC
Patch works for me, thanks.
Comment 3 Larry the Git Cow gentoo-dev 2025-02-19 11:05:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0498e6fbc8a5a9c53234d125fc36f3941635c7b5

commit 0498e6fbc8a5a9c53234d125fc36f3941635c7b5
Author:     Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
AuthorDate: 2025-02-18 22:33:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-02-19 11:04:26 +0000

    sci-geosciences/grass: fix addpredict use
    
    Newer Portage bans use of colons in addpredict calls.
    
    Closes: https://bugs.gentoo.org/948968
    Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
    Closes: https://github.com/gentoo/gentoo/pull/40644
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-geosciences/grass/grass-8.3.2-r1.ebuild  | 26 +++++++++++++++++---------
 sci-geosciences/grass/grass-8.4.0.ebuild     | 26 +++++++++++++++++---------
 sci-geosciences/grass/grass-8.4.1_rc1.ebuild | 26 +++++++++++++++++---------
 sci-geosciences/grass/grass-9999.ebuild      | 26 +++++++++++++++++---------
 4 files changed, 68 insertions(+), 36 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2025-03-10 06:08:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a4fb9adcd287b12f72cf840146a428cd9e12fdd2

commit a4fb9adcd287b12f72cf840146a428cd9e12fdd2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-03-10 06:07:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-10 06:07:36 +0000

    sci-geosciences/grass: fix nullglob vs quoting
    
    Bug: https://bugs.gentoo.org/951100
    Bug: https://bugs.gentoo.org/948968
    Fixes: 0498e6fbc8a5a9c53234d125fc36f3941635c7b5
    Fixes: d8b3a440d5094cccf9be4f2f0df11dd79c869828
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-geosciences/grass/grass-8.3.2-r1.ebuild  | 8 ++++----
 sci-geosciences/grass/grass-8.4.0.ebuild     | 8 ++++----
 sci-geosciences/grass/grass-8.4.1.ebuild     | 8 ++++----
 sci-geosciences/grass/grass-8.4.1_rc1.ebuild | 8 ++++----
 sci-geosciences/grass/grass-9999.ebuild      | 8 ++++----
 5 files changed, 20 insertions(+), 20 deletions(-)