Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 945861 - =sys-apps/portage-3.0.66.1-r1: `sync-webrsync-verify-signature: no` is not respected when using `sync-type: webrsync` to execute `emerge --sync`
Summary: =sys-apps/portage-3.0.66.1-r1: `sync-webrsync-verify-signature: no` is not re...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on: 939444
Blocks:
  Show dependency tree
 
Reported: 2024-12-04 13:34 UTC by Leo Douglas
Modified: 2025-01-22 00:32 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portage-webrsync.patch (portage-webrsync.patch,878 bytes, patch)
2024-12-04 13:34 UTC, Leo Douglas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Douglas 2024-12-04 13:34:54 UTC
Created attachment 913296 [details, diff]
portage-webrsync.patch

How to produce:

1. $ cat eselect-repo.conf
# created by eselect-repo

[gentoo]
sync-type = webrsync
sync-webrsync-verify-signature = no


2. $ emerge --sync

the actual output:

>>> Syncing repository 'gentoo' into '/var/db/repos/gentoo'...
Undefined license group 'BINARY-REDISTRIBUTABLE'
Undefined license group 'EULA'
 * PGP verification method: gemato
 * Fetching most recent snapshot ...
 * Trying to retrieve 20241203 snapshot from https://mirrors.tuna.tsinghua.edu.cn/gentoo ...
 * Fetching file gentoo-20241203.tar.xz.md5sum ...
--2024-12-04 18:45:17--  https://mirrors.tuna.tsinghua.edu.cn/gentoo/snapshots/gentoo-20241203.tar.xz.md5sum
Resolving mirrors.tuna.tsinghua.edu.cn... 101.6.15.130
Connecting to mirrors.tuna.tsinghua.edu.cn|101.6.15.130|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 57 [application/octet-stream]
Saving to: ‘/var/tmp/portage/webrsync-p60OsR/gentoo-20241203.tar.xz.md5sum’

the correct output:

>>> Syncing repository 'gentoo' into '/var/db/repos/gentoo'...
Undefined license group 'BINARY-REDISTRIBUTABLE'
Undefined license group 'EULA'
 * PGP verification method: disabled
 * Fetching most recent snapshot ...
 * Trying to retrieve 20241203 snapshot from https://mirrors.tuna.tsinghua.edu.cn/gentoo ...
 * Fetching file gentoo-20241203.tar.xz.md5sum ...
--2024-12-04 18:46:54--  https://mirrors.tuna.tsinghua.edu.cn/gentoo/snapshots/gentoo-20241203.tar.xz.md5sum
Resolving mirrors.tuna.tsinghua.edu.cn... 101.6.15.130
Connecting to mirrors.tuna.tsinghua.edu.cn|101.6.15.130|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 57 [application/octet-stream]
Saving to: ‘/var/tmp/portage/webrsync-uuSshL/gentoo-20241203.tar.xz.md5sum’



I did some local debugging and found that the reverse logic of sync-webrsync-verify-signature was not handled. Attached is my patch.
Comment 1 Leo Douglas 2024-12-04 13:55:56 UTC
eselect-repo.conf -> /etc/portage/repos.conf/eselect-repo.conf
Comment 2 Zac Medico gentoo-dev 2024-12-05 22:42:20 UTC
The patch looks reasonable.
Comment 3 Larry the Git Cow gentoo-dev 2024-12-07 01:08:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=b39f9f819c34a7a67f2639acb4d4c17a1aa5df89

commit b39f9f819c34a7a67f2639acb4d4c17a1aa5df89
Author:     Leo Douglas <douglarek@gmail.com>
AuthorDate: 2024-12-06 22:08:01 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2024-12-07 00:46:10 +0000

    webrsync: Support sync-webrsync-verify-signature = false
    
    Bug: https://bugs.gentoo.org/945861
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/sync/modules/webrsync/webrsync.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 4 Larry the Git Cow gentoo-dev 2025-01-22 00:30:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=03f41049a0fe0632eabd8cddaaca898e45943201

commit 03f41049a0fe0632eabd8cddaaca898e45943201
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-01-22 00:29:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-22 00:30:02 +0000

    sys-apps/portage: add 3.0.67
    
    Closes: https://bugs.gentoo.org/703520
    Closes: https://bugs.gentoo.org/707980
    Closes: https://bugs.gentoo.org/904702
    Closes: https://bugs.gentoo.org/906044
    Closes: https://bugs.gentoo.org/923530
    Closes: https://bugs.gentoo.org/938164
    Closes: https://bugs.gentoo.org/939299
    Closes: https://bugs.gentoo.org/940120
    Closes: https://bugs.gentoo.org/942512
    Closes: https://bugs.gentoo.org/942760
    Closes: https://bugs.gentoo.org/945382
    Closes: https://bugs.gentoo.org/945861
    Closes: https://bugs.gentoo.org/946326
    Closes: https://bugs.gentoo.org/947822
    Closes: https://bugs.gentoo.org/948067
    Closes: https://bugs.gentoo.org/939444
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.67.ebuild | 231 +++++++++++++++++++++++++++++++++
 2 files changed, 232 insertions(+)