Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 941161 - app-crypt/mit-krb5 ebuild missing sys-fs/e2fsprogs in BDEPEND
Summary: app-crypt/mit-krb5 ebuild missing sys-fs/e2fsprogs in BDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Kerberos Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-08 14:07 UTC by fsandrade
Modified: 2024-11-20 17:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Sample logs from bazel build failures (file_941161.txt,2.05 KB, text/plain)
2024-10-08 14:07 UTC, fsandrade
Details

Note You need to log in before you can comment on or make changes to this bug.
Description fsandrade 2024-10-08 14:07:38 UTC
Created attachment 905110 [details]
Sample logs from bazel build failures

Description:

The ebuild file in app-crypt/mit-krb5 is missing a BDEPEND line for sys-fs/e2fsprogs.

That fix was recently added in portage-stable to the corresponding package in chromiumos:
https://chromium-review.googlesource.com/c/chromiumos/overlays/portage-stable/+/5872808

Before that fix, the hack removed in the commit below was necessary to satisfy the dependencies for the bazel builder: 
https://chromium-review.googlesource.com/c/chromiumos/bazel/+/5882733

See the attached text containing logs from bazel build failures.
Comment 1 Larry the Git Cow gentoo-dev 2024-10-12 07:59:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de41a3ba38ba1ccb98bae20e443a1af8d8df5c6a

commit de41a3ba38ba1ccb98bae20e443a1af8d8df5c6a
Author:     Eray Aslan <eras@gentoo.org>
AuthorDate: 2024-10-12 07:59:01 +0000
Commit:     Eray Aslan <eras@gentoo.org>
CommitDate: 2024-10-12 07:59:30 +0000

    app-crypt/mit-krb5: Add missing sys-fs/e2fsprogs to BDEPEND
    
    Closes: https://bugs.gentoo.org/941161
    Signed-off-by: Eray Aslan <eras@gentoo.org>

 app-crypt/mit-krb5/mit-krb5-1.21.3-r1.ebuild | 155 +++++++++++++++++++++++++++
 1 file changed, 155 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2024-11-20 15:59:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9b2189299965e24e16cc8f746a427351f8b6390

commit c9b2189299965e24e16cc8f746a427351f8b6390
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-11-20 15:53:16 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-11-20 15:59:12 +0000

    Revert "app-crypt/mit-krb5: Add missing sys-fs/e2fsprogs to BDEPEND"
    
    It is never appropriate to use MULTILIB_USEDEP in BDEPEND. Library
    depdnedencies belong in DEPEND.
    
    This also breaks cross-compiles.
    
    Bug: https://bugs.gentoo.org/941161
    Closes: https://bugs.gentoo.org/944040
    Reverts: de41a3ba38ba1ccb98bae20e443a1af8d8df5c6a
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 app-crypt/mit-krb5/mit-krb5-1.21.3-r1.ebuild | 155 ---------------------------
 1 file changed, 155 deletions(-)
Comment 3 fsandrade 2024-11-20 16:17:36 UTC
After the revert linked in comment #2, this issue became unresolved again.

According to the description of https://bugs.gentoo.org/944040, it seems like the correct way to add the missing BDEPEND entry here is:

sys-fs/e2fsprogs

instead of:

>=sys-fs/e2fsprogs-1.46.4-r51[${MULTILIB_USEDEP}]
Comment 4 fsandrade 2024-11-20 17:00:56 UTC
This has just been fixed in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ecfa736b2857801df98cbe35acd84acd6fa65b5 .

Thank you floppym@gentoo.org for the fix!