Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 938156 - games-emulation/ppsspp-1.17.1-r1 fails to compile: SpvBuilder.h:236:30: error: uint32_t has not been declared
Summary: games-emulation/ppsspp-1.17.1-r1 fails to compile: SpvBuilder.h:236:30: error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Maciej Barć
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: gcc-15
  Show dependency tree
 
Reported: 2024-08-18 17:50 UTC by Agostino Sarubbo
Modified: 2024-11-14 23:40 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.xz (build.log.xz,42.12 KB, application/x-xz)
2024-08-18 17:50 UTC, Agostino Sarubbo
Details
includes cstdint for ext/glslang/SPIRV/SpvBuilder.h b/ext/glslang/SPIRV/SpvBuilder.h (cstdint-for-SpvBuilder.h.patch,627 bytes, patch)
2024-11-14 22:37 UTC, tdr
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-08-18 17:50:11 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-emulation/ppsspp-1.17.1-r1 fails to compile.
Discovered on: amd64 (internal ref: gcc15_tinderbox)
System: GCC-15-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-15)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0014
Comment 1 Agostino Sarubbo gentoo-dev 2024-08-18 17:50:12 UTC
Created attachment 900577 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)
Comment 2 Agostino Sarubbo gentoo-dev 2024-08-18 17:50:13 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


  Could not find a package configuration file provided by "SDL2_ttf" with any
  git not found, unable to include version.
-- Could NOT find WAYLAND (missing: WAYLAND_LIBRARIES WAYLAND_INCLUDE_DIR) 
-- Could NOT find WAYLAND_CLIENT (missing: WAYLAND_CLIENT_LIBRARIES WAYLAND_CLIENT_INCLUDE_DIR) 
-- Could NOT find WAYLAND_CURSOR (missing: WAYLAND_CURSOR_LIBRARIES WAYLAND_CURSOR_INCLUDE_DIR) 
-- Could NOT find WAYLAND_EGL (missing: WAYLAND_EGL_LIBRARIES WAYLAND_EGL_INCLUDE_DIR) 
-- Could NOT find WAYLAND_SERVER (missing: WAYLAND_SERVER_LIBRARIES WAYLAND_SERVER_INCLUDE_DIR) 
-- Could not find Wayland libraries, disabling Wayland WSI support for Vulkan.
-- Google Mock was not found - tests based on that will not build
FAILED: ext/glslang/SPIRV/CMakeFiles/SPIRV.dir/SpvBuilder.cpp.o 
FAILED: ext/glslang/SPIRV/CMakeFiles/SPIRV.dir/SpvPostProcess.cpp.o 
/var/tmp/portage/games-emulation/ppsspp-1.17.1-r1/work/ppsspp-1.17.1/ext/glslang/SPIRV/SpvBuilder.h:236:30: error: ‘uint32_t’ has not been declared
Comment 3 tdr 2024-11-14 22:37:00 UTC
Created attachment 908720 [details, diff]
includes cstdint for ext/glslang/SPIRV/SpvBuilder.h b/ext/glslang/SPIRV/SpvBuilder.h
Comment 4 tdr 2024-11-14 22:43:54 UTC
Patch uploaded to include cstdint into a header

Created/applied/tested with =sys-devel/gcc-15.0.0_pre20241110
Comment 5 Maciej Barć gentoo-dev 2024-11-14 22:48:01 UTC
(In reply to tdr from comment #4)
> Patch uploaded to include cstdint into a header
> 
> Created/applied/tested with =sys-devel/gcc-15.0.0_pre20241110

Thanks!
Comment 6 immolo 2024-11-14 22:50:15 UTC
Thanks! Tested and works fine here, please upstream and link PR back here.

Test project /var/tmp/portage/games-emulation/ppsspp-1.17.1-r1/work/ppsspp-1.17.1_build
      Start  1: arm64_emitter
      Start  2: arm_emitter
      Start  3: x64_emitter
      Start  4: vertex_jit
      Start  5: asin
      Start  6: sincos
      Start  7: vfpu_sincos
      Start  8: math_util
      Start  9: parsers
      Start 10: jit
      Start 11: matrix_transpose
      Start 12: parse_lbn
      Start 13: quick_texhash
      Start 14: clz
      Start 15: shadergen
 1/15 Test  #3: x64_emitter ......................   Passed    0.03 sec
 2/15 Test  #5: asin .............................   Passed    0.03 sec
 3/15 Test  #1: arm64_emitter ....................   Passed    0.03 sec
 4/15 Test  #2: arm_emitter ......................   Passed    0.03 sec
 5/15 Test  #6: sincos ...........................   Passed    0.03 sec
 6/15 Test  #7: vfpu_sincos ......................   Passed    0.03 sec
 7/15 Test  #9: parsers ..........................   Passed    0.02 sec
 8/15 Test #11: matrix_transpose .................   Passed    0.02 sec
 9/15 Test  #8: math_util ........................   Passed    0.03 sec
10/15 Test #12: parse_lbn ........................   Passed    0.02 sec
11/15 Test #13: quick_texhash ....................   Passed    0.02 sec
12/15 Test #14: clz ..............................   Passed    0.02 sec
13/15 Test #15: shadergen ........................   Passed    0.48 sec
14/15 Test  #4: vertex_jit .......................   Passed    1.07 sec
15/15 Test #10: jit ..............................   Passed    2.08 sec

100% tests passed, 0 tests failed out of 15

Total Test time (real) =   2.09 sec
 * Tests succeeded.
Comment 7 Maciej Barć gentoo-dev 2024-11-14 22:53:24 UTC
(In reply to immolo from comment #6)
> Thanks! Tested and works fine here, please upstream and link PR back here.

No need for PR on GH, I will merge the attached patch.
Comment 8 Larry the Git Cow gentoo-dev 2024-11-14 23:40:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e288ff2fc71f2efb259f22473a78a91044fc472

commit 0e288ff2fc71f2efb259f22473a78a91044fc472
Author:     Maciej Barć <xgqt@gentoo.org>
AuthorDate: 2024-11-14 23:26:11 +0000
Commit:     Maciej Barć <xgqt@gentoo.org>
CommitDate: 2024-11-14 23:40:54 +0000

    games-emulation/ppsspp: patch SpvBuilder - include cstdint
    
    Closes: https://bugs.gentoo.org/938156
    Signed-off-by: Maciej Barć <xgqt@gentoo.org>

 .../files/ppsspp-1.17.1-SpvBuilder-cstdint.patch   | 23 ++++++++++++++++++++++
 ...pp-1.17.1-r1.ebuild => ppsspp-1.17.1-r2.ebuild} |  1 +
 2 files changed, 24 insertions(+)